[PATCH][3/11] IB: sparse fixes

From: Roland Dreier (roland_at_topspin.com)
Date: 03/03/05

  • Next message: Benjamin Herrenschmidt: "Re: Page fault scalability patch V18: Drop first acquisition of ptl"
    Date:	Wed, 2 Mar 2005 21:31:22 -0800
    To: akpm@osdl.org
    
    

    From: Tom Duffy <tduffy@sun.com>

    Fix some sparse warnings by making sure we have appropriate "extern"
    declarations visible.

    Signed-off-by: Tom Duffy <tduffy@sun.com>
    Signed-off-by: Hal Rosenstock (<halr@voltaire.com>
    Signed-off-by: Roland Dreier <roland@topspin.com>

    --- linux-export.orig/drivers/infiniband/core/agent.c 2005-03-02 20:26:10.599187430 -0800
    +++ linux-export/drivers/infiniband/core/agent.c 2005-03-02 20:26:11.456001445 -0800
    @@ -45,14 +45,11 @@
     #include "smi.h"
     #include "agent_priv.h"
     #include "mad_priv.h"
    -
    +#include "agent.h"
     
     spinlock_t ib_agent_port_list_lock;
     static LIST_HEAD(ib_agent_port_list);
     
    -extern kmem_cache_t *ib_mad_cache;
    -
    -
     /*
      * Caller must hold ib_agent_port_list_lock
      */
    --- linux-export.orig/drivers/infiniband/core/cache.c 2005-03-02 20:26:03.085818330 -0800
    +++ linux-export/drivers/infiniband/core/cache.c 2005-03-02 20:26:11.456001445 -0800
    @@ -37,6 +37,8 @@
     #include <linux/errno.h>
     #include <linux/slab.h>
     
    +#include <ib_cache.h>
    +
     #include "core_priv.h"
     
     struct ib_pkey_cache {
    --- linux-export.orig/drivers/infiniband/core/mad_priv.h 2005-03-02 20:26:10.980104746 -0800
    +++ linux-export/drivers/infiniband/core/mad_priv.h 2005-03-02 20:26:11.457001228 -0800
    @@ -192,4 +192,6 @@
             struct ib_mad_qp_info qp_info[IB_MAD_QPS_CORE];
     };
     
    +extern kmem_cache_t *ib_mad_cache;
    +
     #endif /* __IB_MAD_PRIV_H__ */
    --- linux-export.orig/drivers/infiniband/core/smi.c 2005-03-02 20:26:03.085818330 -0800
    +++ linux-export/drivers/infiniband/core/smi.c 2005-03-02 20:26:11.458001011 -0800
    @@ -37,7 +37,7 @@
      */
     
     #include <ib_smi.h>
    -
    +#include "smi.h"
     
     /*
      * Fixup a directed route SMP for sending

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Benjamin Herrenschmidt: "Re: Page fault scalability patch V18: Drop first acquisition of ptl"

    Relevant Pages

    • RE: [PATCH][2.4.30-rc1] updated gcc-4.0 patches
      ... -extern volatile struct OpenPIC *OpenPIC; ... extern struct cpuinfo_x86 boot_cpu_data; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] rmap 6 swap_unplug page
      ... to unplug all swap devices. ... extern int swap_readpage(struct file *, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] remove unnecessary #includes from <linux/fs.h>
      ... >> everything being rebuilt just because one header file was touched. ... struct nameidata; ... extern int is_subdir ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] remove unused ide_devices_t from ide.c and ide.h
      ... extern ide_driver_t idedefault_driver; ... -typedef struct ide_devices_s { ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: [RFC] Generalize prio_tree (1/3)
      ... Hmm, GET_INDEX/get_index grows and grows, and also generates a ... And what if we took the hit and moved the key into struct ... half of the key is free (in terms of storage - the key updates ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)