Re: [PATCH][3/26] IB/mthca: improve CQ locking part 1

From: Jeff Garzik (jgarzik_at_pobox.com)
Date: 03/04/05

  • Next message: Pierre Ossman: "Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11"
    Date:	Thu, 03 Mar 2005 19:35:00 -0500
    To: Roland Dreier <roland@topspin.com>
    
    

    Roland Dreier wrote:
    > @@ -783,6 +777,11 @@
    > cq->cqn & (dev->limits.num_cqs - 1));
    > spin_unlock_irq(&dev->cq_table.lock);
    >
    > + if (dev->mthca_flags & MTHCA_FLAG_MSI_X)
    > + synchronize_irq(dev->eq_table.eq[MTHCA_EQ_COMP].msi_x_vector);
    > + else
    > + synchronize_irq(dev->pdev->irq);
    > +

    Tangent: I think we need a pci_irq_sync() rather than putting the above
    code into each driver.

            Jeff

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Pierre Ossman: "Re: [Alsa-devel] Re: intel 8x0 went silent in 2.6.11"

    Relevant Pages

    • Re: My thoughts on the "new development model"
      ... |>>> 2.6 tree is great for gentoo users who like gcc consuming all CPU ... |>> that after a month or so of fixes etc it will be a very stable kernel ... driver for 2.6.7 for an ADSL card; a development driver for 2.6.5 for a ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: Error mounting root fs on 72:01 using Promise FastTrak TX2000 (PDC20271)
      ... The Promise ataraid driver never gets loaded. ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • (no subject)
      ... > driver layer is needed to handle these operations cleanly. ... Device addition and removal work just fine with that scheme. ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: sata related hang with linux-2.6
      ... IMHO there's something not quite right with the Silicon Image libata ... Perhaps the driver is enabling the hardware to generate interrupts ... before setting up the interrupt routine for it? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: SL811 problem on mach-pxa
      ... It was tested with _both_ workarounds for IRQ issues; ... unlike the predecessors to this driver). ... I've had reports that one of the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)