Re: PCMCIA product id strings -> hashes generation at compilation time? [Was: Re: [patch 14/38] pcmcia: id_table for wavelan_cs]

From: Linus Torvalds (torvalds_at_osdl.org)
Date: 03/08/05

  • Next message: Bagalkote, Sreenivas: "RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers" 
    Date:	Tue, 8 Mar 2005 14:54:57 -0800 (PST)
To: Dominik Brodowski <linux@dominikbrodowski.net>

    On Tue, 8 Mar 2005, Dominik Brodowski wrote:
    >
    > Unfortunately, these strings cannot
    > be passed to userspace for easy userspace-based loading of appropriate
    > modules (MODNAME -- hotplug), so my suggestion is to also store crc32 hashes
    > of the strings in the MODULE_DEVICE_TABLEs, e.g.:
    >
    > PCMCIA_DEVICE_PROD_ID12("LINKSYS", "E-CARD", 0xf7cb0b07, 0x6701da11),

    Hmm.. I'm with Andrew on this one - I'd much rather really pass them to
    user space as strings. We already pass a number of strings as environment
    variables.

    In fact, what's wrong with DEVPATH? Which we already expose as the
    NAME=xxx environment variable. So if the kboject associated with a device
    has has this string associated with its name (which it should), then
    hotplug will automatially pass that as the DEVPATH.

    So if you just fill out the kobject name with the product ID's (well,
    with the proper escaping of strange characters, of course), everything
    should just work. No?

                    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Bagalkote, Sreenivas: "RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers"