RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

From: Bodo Eggert (7eggert_at_gmx.de)
Date: 03/09/05

  • Next message: David Howells: "[PATCH] keys: Discard key spinlock and use RCU for key payload" 
    To: Bagalkote@arcor-online.net, Sreenivas <sreenib@lsil.com>, linux-kernel@vger.kernel.org
Date:	Wed, 09 Mar 2005 18:59:22 +0100

    Bagalkote, Sreenivas <sreenib@lsil.com> wrote:

    >>> . And since this is compile time
    >>> system-wide property, I kept it as driver global.
    >>
    >>that step I don't understand... why is it a global *VARIABLE* if it's
    >>compile time system-wide property...
    >>
    >
    > I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8)
    > instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier?
    > Please advice.

    If using a static const variable produces about the same code a macro does,
    the variable is OK. Otherwise you'll have to use a #define in order to avoid
    including dead code.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: David Howells: "[PATCH] keys: Discard key spinlock and use RCU for key payload"

    Relevant Pages

    • Re: [RFC] add kobject to struct module
      ... > - Are we opening the floodgates for another round of races and driver ... If you set the "perm" portion of the module_parammacro to 0, ... perm sets the visibility in driverfs: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch 1/1] dm: fix printk warnings about whether %lu/%Lu is right for sector_t
      ... Why cannot we simply define the macro in linux/types.h and go along? ... no reason at all for arch-dependent definition of this macro; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: NUMA aware slab allocator V2
      ... >> Could we boot the box without quiet so that we can get better debug ... define this is_node_onlinemacro, as node_onlinedoes EXACTLY the same ... with for_each_nodeand the one loop that does this: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Patch] invalidate range of pages after direct IO write
      ... > Andrew Morton wrote: ... >> I'd be inclined to hold off on the macro until we actually get the ... > function pointer from the caller will turn people's stomachs. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: out-of-line x86 "put_user()" implementation
      ... macro). ... Andrew - do you want to put it in -mm? ... - Write a simple value into user space. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)