Re: 2.6.11-mm3 breaks compile of drivers/char/esp.c

From: Andrew Morton (akpm_at_osdl.org)
Date: 03/15/05

  • Next message: Stephen Rothwell: "[PATCH] PPC64 iSeries: cleanup iSeries_setup"
    Date:	Mon, 14 Mar 2005 20:33:57 -0800
    To: Bernhard Rosenkraenzer <bero@arklinux.org>
    
    

    Bernhard Rosenkraenzer <bero@arklinux.org> wrote:
    >
    > drivers/char/esp.c: In function 'rs_stop':
    > drivers/char/esp.c:213: error: 'struct esp_struct' has no member named 'lock'
    > drivers/char/esp.c:219: error: 'struct esp_struct' has no member named 'lock'
    > drivers/char/esp.c: In function 'rs_start':
    > drivers/char/esp.c:230: error: 'struct esp_struct' has no member named 'lock'
    > drivers/char/esp.c:236: error: 'struct esp_struct' has no member named 'lock'

    Seems that Alan's diff was missing the changes to the header file. Like
    this?

    --- 25/include/linux/hayesesp.h~esp-build-fix 2005-03-14 20:31:18.000000000 -0800
    +++ 25-akpm/include/linux/hayesesp.h 2005-03-14 20:31:30.000000000 -0800
    @@ -77,6 +77,7 @@ struct hayes_esp_config {
     
     struct esp_struct {
             int magic;
    + spinlock_t lock;
             int port;
             int irq;
             int flags; /* defined in tty.h */
    _
     

    I didn't pick this up because ESPSERIAL is still BROKEN_ON_SMP. Alan,
    should we remove that now?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Stephen Rothwell: "[PATCH] PPC64 iSeries: cleanup iSeries_setup"

    Relevant Pages

    • [PATCH] remove unnecessary #includes from <linux/fs.h>
      ... >> everything being rebuilt just because one header file was touched. ... struct nameidata; ... extern int is_subdir ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Fix missing padding in DMI table.
      ... This entry in the DMI blacklist table is missing it's NO_MATCH ... tags, which means the struct gets padded instead of filled with ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.6.0-test6
      ... and gcc warns that "struct task_struct" has not been declared, ... Just declare the structure ... everything being rebuilt just because one header file was touched. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.13-rc3-mm3
      ... Also please test 2.6.13-rc4-mm1 which is missing the acpi tree... ... static struct sonypi_device { ... +static void sonypi_report_input_event ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: anon_vma RFC2
      ... > pointers in the page struct. ... what you are missing is that we don't need a prio_tree at all with ... the vm_pgoff is meaningless with anonmm. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)