Re: ppc64 build broke between 2.6.11-bk6 and 2.6.11-bk7

From: Joel Schopp (jschopp_at_austin.ibm.com)
Date: 03/18/05

  • Next message: Bartlomiej Zolnierkiewicz: "[BK PATCHES] ide-2.6 update" 
    Date:	Fri, 18 Mar 2005 10:24:20 -0600
To: Mikael Pettersson <mikpe@csd.uu.se>

    Mikael Pettersson wrote:
    > Andrew Morton writes:
    > > "Martin J. Bligh" <mbligh@aracnet.com> wrote:
    > > >
    > > > drivers/built-in.o(.text+0x182bc): In function `.matroxfb_probe':
    > > > : undefined reference to `.mac_vmode_to_var'
    > > > make: *** [.tmp_vmlinux1] Error 1
    > > >
    > > > Anyone know what that is?
    > > >
    > >
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11-mm4/broken-out/fbdev-kconfig-fix-for-macmodes-and-ppc.patch
    > >
    > > should fix it.
    >
    > It seems the culprit is "matroxfb-compile-error.patch" which unconditionally adds
    > macmodes.o to the Makefile line for CONFIG_FB_MATROX. This obviously breaks on !ppc.
    > The patch Andrew mentions above converts the Kconfig entry for FB_MATROX to do a
    > "select FB_MACMODES if PPC_PMAC", so dropping matroxfb-compile-error.patch should suffice.
    >
    >

    matroxfb-compile-error.patch was a valid fix for a compile problem. It
    was against 2.6.11-bk10, therefore wasn't in the 2.6.11-bk6 or 2.6.11bk7
    you had problems with and didn't cause this mess to begin with.

    It appears the problem was more systemic than what I saw during my
    compile, thus the fbdev-kconfig-fix-for-macmodes-and-ppc.patch probably
    fixes the problem I fixed and a host of others. Of course it conflicts
    with my patch.

    Please drop the matroxfb-compile-error.patch and if the problem isn't
    truly fixed by fbdev-kconfig-fix-for-macmodes-and-ppc.patch I will
    resend it.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Bartlomiej Zolnierkiewicz: "[BK PATCHES] ide-2.6 update"

    Relevant Pages

    • Re: 2.6.13-rc3-mm3
      ... On Thu, 28 Jul 2005, Andrew Morton wrote: ... becoming a common case for multi-core applications. ... I have just sent a fix to you this morning when I got your messages. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc2-mm2
      ... On Wed, 22 Sep 2004, Andrew Morton wrote: ... but which exact patch of those listed does fix this problem? ... Or is the fix ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.10-rc1-mm5 [u]
      ... On Sat, 2004-11-13 at 13:22 -0800, Andrew Morton wrote: ... > the retest? ... this seems to fix it (usually one thread at least have already hung ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Soft lockup with -mm
      ... Brice Goglin a écrit: ... > Andrew Morton a écrit: ... This box is running 2.6.12-rc3-mm2 with Oleg's fix for 12 days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ppc64 build broke between 2.6.11-bk6 and 2.6.11-bk7
      ... Andrew Morton writes: ... The patch Andrew mentions above converts the Kconfig entry for FB_MATROX to do a ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)