[2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use

From: Adrian Bunk (bunk_at_stusta.de)
Date: 03/27/05

  • Next message: Adrian Bunk: "[2.6 patch] fs/udf/inode.c: fix a check after use"
    Date:	Sun, 27 Mar 2005 22:44:47 +0200
    To: linux-kernel@vger.kernel.org
    
    

    This patch fixes a check after use found by the Coverity checker.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.12-rc1-mm1-full/drivers/net/pcmcia/nmclan_cs.c.old 2005-03-23 05:04:00.000000000 +0100
    +++ linux-2.6.12-rc1-mm1-full/drivers/net/pcmcia/nmclan_cs.c 2005-03-23 05:04:30.000000000 +0100
    @@ -1090,20 +1090,22 @@
     ---------------------------------------------------------------------------- */
     static irqreturn_t mace_interrupt(int irq, void *dev_id, struct pt_regs *regs)
     {
       struct net_device *dev = (struct net_device *) dev_id;
       mace_private *lp = netdev_priv(dev);
    - kio_addr_t ioaddr = dev->base_addr;
    + kio_addr_t ioaddr;
       int status;
       int IntrCnt = MACE_MAX_IR_ITERATIONS;
     
       if (dev == NULL) {
         DEBUG(2, "mace_interrupt(): irq 0x%X for unknown device.\n",
               irq);
         return IRQ_NONE;
       }
     
    + ioaddr = dev->base_addr;
    +
       if (lp->tx_irq_disabled) {
         printk(
           (lp->tx_irq_disabled?
            KERN_NOTICE "%s: Interrupt with tx_irq_disabled "
            "[isr=%02X, imr=%02X]\n":

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Adrian Bunk: "[2.6 patch] fs/udf/inode.c: fix a check after use"

    Relevant Pages

    • Re: spurious C warnings..
      ... 6809 home system - so I still tend to avoid making assumptions ... Anyway, your explanation makes sense. ... It first tries for int, ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: Beginner has trouble with SDL in foll-screen mode.
      ... In full-screen mode everything is sheared off into wavy lines, ... Uint8 green, ... int x, y, t; ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: Beginner has trouble with SDL in foll-screen mode.
      ... In full-screen mode everything is sheared off into wavy lines, ... Uint8 green, ... int x, y, t; ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: spurious C warnings..
      ... The ULL suffix does indeed seem to have the desired effect, ... It first tries for int, ... is for consistency with other type qualifiers, especially floats. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)
    • Re: amd64: why is sizeof(int) =4? why not =8?
      ... Symbolic names are unreliable, int may be anything ... thus not using anything not part of the C standard. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)