[2.6 patch] drivers/pci/msi.c: fix a check after use

From: Adrian Bunk (bunk_at_stusta.de)
Date: 03/27/05

  • Next message: Adrian Bunk: "[2.6 patch] sound/oss/rme96xx.c: fix two check after use"
    Date:	Sun, 27 Mar 2005 23:15:24 +0200
    To: tom.l.nguyen@intel.com
    
    

    This patch fixes a check after use found by the Coverity checker.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 04:46:30.000000000 +0100
    +++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.000000000 +0100
    @@ -703,12 +703,14 @@
      **/
     int pci_enable_msi(struct pci_dev* dev)
     {
    - int pos, temp = dev->irq, status = -EINVAL;
    + int pos, temp, status = -EINVAL;
             u16 control;
     
             if (!pci_msi_enable || !dev)
                      return status;
     
    + temp = dev->irq;
    +
             if ((status = msi_init()) < 0)
                     return status;
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Adrian Bunk: "[2.6 patch] sound/oss/rme96xx.c: fix two check after use"

    Relevant Pages

    • Re: spurious C warnings..
      ... 6809 home system - so I still tend to avoid making assumptions ... Anyway, your explanation makes sense. ... It first tries for int, ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: [PATCH 2.6.10-rc1 5/5] driver-model: device_add() error path reference counting fix
      ... In device_add(), @dev wan't put'd properly when it has zero length ... bus_id (error path). ... int device_add ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Beginner has trouble with SDL in foll-screen mode.
      ... In full-screen mode everything is sheared off into wavy lines, ... Uint8 green, ... int x, y, t; ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: Beginner has trouble with SDL in foll-screen mode.
      ... In full-screen mode everything is sheared off into wavy lines, ... Uint8 green, ... int x, y, t; ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Re: spurious C warnings..
      ... The ULL suffix does indeed seem to have the desired effect, ... It first tries for int, ... is for consistency with other type qualifiers, especially floats. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)