Re: klists and struct device semaphores

From: Dmitry Torokhov (dmitry.torokhov_at_gmail.com)
Date: 03/29/05

  • Next message: Steven Cole: "[PATCH] 2.6.12-rc1-mm3 Fix ver_linux script for no udev utils."
    Date:	Tue, 29 Mar 2005 11:26:17 -0500
    To: Alan Stern <stern@rowland.harvard.edu>
    
    

    On Tue, 29 Mar 2005 11:18:13 -0500 (EST), Alan Stern
    <stern@rowland.harvard.edu> wrote:
    >
    > With that change in place we can guarantee that every time a USB driver's
    > probe() is called, both the interface and the parent device are locked.
    >
    > I don't know how cleanly this can be implemented. You probably don't want
    > to lock dev->parent->sem every time, only when needed. Maybe the simplest
    > approach would be to add a flag in struct bus_type, which could be set for
    > the USB bus_type and clear for everything else.
    >

    I think it is fine to lock parent unconditionally. After all
    device/driver matching is not the most performance-critical part of
    the kernel.

    -- 
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Steven Cole: "[PATCH] 2.6.12-rc1-mm3 Fix ver_linux script for no udev utils."

    Relevant Pages

    • Re: usb/cups printer problem after etch upgrade
      ... and the attributes from one single parent device. ... serial number is found by the USB backend of CUPS. ... configuration files during the upgrade. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
      (Debian-User)
    • Re: Totally broken PCI PM calls
      ... I'm thinking of the case of Cardbus with hotpluggable PCI buses. ... to being inappropriately setup. ... problem is present with USB, and USB is far more liable to have this ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC [patch 13/34] PID Virtualization Define new task_pid api
      ... > Most of the calls involving resource ids will return values that aren't ... At that point getppidwill return 0, and getpid() will return 1. ... Now there will be a pid that the parent sees that will not be 0. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC [patch 13/34] PID Virtualization Define new task_pid api
      ... For the most part I am not breaking the usual process semantics I work ... very hard to preserve it but simply which pids you see are different. ... >> Now there will be a pid that the parent sees that will not be 0. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: more files with licenses that arent GPL-compatible
      ... strange license text) we got that solved easily. ... If one of you usb guys want to convert it that's fine, ... get the files relicensed under a GPL-compatible license that's fine aswell, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)