PCI Hotplug: enforce the rule that a hotplug slot needs a release function.

From: Greg KH (gregkh_at_suse.de)
Date: 04/02/05

  • Next message: Greg KH: "[PATCH] drivers/pci/msi.c: fix a check after use" 
    Date:	Fri, 1 Apr 2005 15:47:53 -0800
To: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz

    ChangeSet 1.2181.16.17, 2005/03/21 22:55:26-08:00, gregkh@suse.de

    PCI Hotplug: enforce the rule that a hotplug slot needs a release function.

    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

     drivers/pci/hotplug/pci_hotplug_core.c | 5 +++++
     1 files changed, 5 insertions(+)

    diff -Nru a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
    --- a/drivers/pci/hotplug/pci_hotplug_core.c 2005-04-01 15:34:15 -08:00
    +++ b/drivers/pci/hotplug/pci_hotplug_core.c 2005-04-01 15:34:15 -08:00
    @@ -567,6 +567,11 @@
                     return -ENODEV;
             if ((slot->info == NULL) || (slot->ops == NULL))
                     return -EINVAL;
    + if (slot->release == NULL) {
    + dbg("Why are you trying to register a hotplug slot"
    + "without a proper release function?\n");
    + return -EINVAL;
    + }
     
             kobject_set_name(&slot->kobj, "%s", slot->name);
             kobj_set_kset_s(slot, pci_hotplug_slots_subsys);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg KH: "[PATCH] drivers/pci/msi.c: fix a check after use"

    Relevant Pages