Re: [PATCH 00/04] Load keyspan firmware with hotplug

From: Dmitry Torokhov (dmitry.torokhov_at_gmail.com)
Date: 04/05/05

  • Next message: Jörn Engel: "Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()" 
    Date:	Tue, 5 Apr 2005 11:20:13 -0500
To: Marcel Holtmann <marcel@holtmann.org>, Dmitry Torokhov <dtor_core@ameritech.net>, Jan Harkes <jaharkes@cs.cmu.edu>, Greg KH <greg@kroah.com>, Sven Luther <sven.luther@wanadoo.fr>, Michael Poole <mdpoole@troilus.org>, debian-legal@lists.debian.org, debian-kernel@lists.debian.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>

    On Apr 5, 2005 6:45 AM, Jan Harkes <jaharkes@cs.cmu.edu> wrote:
    > On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote:
    > > I agree with Dmitry on this point. The IHEX parser should not be inside
    > > firmware_class.c. What about using keyspan_ihex.[ch] for it?
    >
    > That's what I had originally, actually called firmware_ihex.ko, since
    > the IHEX format parser is not in any way keyspan specific and there are
    > several usb-serial converters that seem to use the same IHEX->.h trick
    > which could trivially be modified to use this loader.
    >
    > But the compiled parser fairly small (< 2KB) and adding it to the
    > existing module didn't effectively add any size to the firmware_class
    > module since things are rounded to a page boundary anyways.
    >

    It is not about the size, it is about source separation. Since it has
    nothing to do with actualy loading of a BLOB from userspace to kernel
    space I'd put it into lib/, like crc functions, etc. It does not
    really have to work with "struct firmware *", "void *data, size_t len"
    should be just as useable. 

    -- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Jörn Engel: "Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()"

    Relevant Pages

    • Re: [PATCH 00/04] Load keyspan firmware with hotplug
      ... >> following series of patches? ... > Firmware loader is format-agnostic, I think having IHEX parser in a separate ... The IHEX parser should not be inside ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] embedding 2.6 or more findings on kernel size
      ... Dmitry ... perhaps would find more) when the kernel was compiled with ... and the third thing I found is that scsi_ioctl is compiled even if SCSI ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: OpenGL in the kernel
      ... > I heard a few about future OpenGL implementation in the Linux kernel, ... > With best regards, Dmitry M. Shatrov ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 PATCH/RFC] Firmware loader fixes - take 2
      ... > Hi Dmitry, ... > code to the kernel and have an own way of running hotplug. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)