[PATCH] s390: drop redundant NULL pointer checks before kfree()

• Previous message: Michael Poole: "Re: non-free firmware in kernel modules, aggregation and unclear copyright notice."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Date:	Mon, 11 Apr 2005 21:46:18 +0200 (CEST)
To: Martin Schwidefsky <schwidefsky@de.ibm.com>

(please keep me on CC when replying)

Checking for NULL before calling kfree() on a pointer is redundant. This
patch drops such checks from arch/s390/

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

---
 extmem.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff -upr linux-2.6.12-rc2-mm3-orig/arch/s390/mm/extmem.c linux-2.6.12-rc2-mm3/arch/s390/mm/extmem.c
--- linux-2.6.12-rc2-mm3-orig/arch/s390/mm/extmem.c	2005-03-02 08:38:17.000000000 +0100
+++ linux-2.6.12-rc2-mm3/arch/s390/mm/extmem.c	2005-04-11 21:40:10.000000000 +0200
@@ -234,8 +234,8 @@ query_segment_type (struct dcss_segment 
 	rc = 0;
 
  out_free:
-	if (qin) kfree(qin);
-	if (qout) kfree(qout);
+	kfree(qin);
+	kfree(qout);
 	return rc;
 }
 
@@ -394,7 +394,7 @@ __segment_load (char *name, int do_nonsh
 				segtype_string[seg->vm_segtype]);
 	goto out;
  out_free:
-	kfree (seg);
+	kfree(seg);
  out:
 	return rc;
 }
@@ -505,7 +505,7 @@ segment_modify_shared (char *name, int d
 	list_del(&seg->list);
 	dcss_diag(DCSS_PURGESEG, seg->dcss_name,
 		  &dummy, &dummy);
-	kfree (seg);
+	kfree(seg);
  out_unlock:
 	spin_unlock(&dcss_lock);
 	return rc;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Previous message: Michael Poole: "Re: non-free firmware in kernel modules, aggregation and unclear copyright notice."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]