Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
From: Christoph Hellwig (hch_at_infradead.org)
Date: 04/13/05
- Previous message: Linus Torvalds: "Re: Re: [ANNOUNCE] git-pasky-0.3"
- In reply to: Bodo Eggert
: "Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use" - Next in thread: Al Viro: "Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 13 Apr 2005 15:58:46 +0100 To: "Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>" <7eggert@gmx.de>
On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org> wrote:
> If there are checks, they should be there for a purpose,
emphasis here is on _should_
> and any sane reader will asume these checks to be nescensary.
That's a bad assumptions when you're deadling with drivers or software of
similar quality.
> If they are dead code, you
> can say that, but please don't flame Adrian for fixing obviously buggy code
> in a way that is sane and at least more correct than the original without
> using several days of his lifetime to analyze the whole driver. Instead, you
> could provide the correct fix.
The correct fix is to remove the check. And no, we don't have a rule that
someone must provide something better when trying to critize it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Linus Torvalds: "Re: Re: [ANNOUNCE] git-pasky-0.3"
- In reply to: Bodo Eggert
: "Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use" - Next in thread: Al Viro: "Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
