[PATCH] rename "---help---" to "help" in Kconfig files

From: Jesper Juhl (juhl-lkml_at_dif.dk)
Date: 04/21/05

Next message: Gabriel Jägenstedt: "Re: Booting from USB with initrd"

Previous message: Phillip Lougher: "Re: [PATCH] remove some usesless casts"
Next in thread: Adrian Bunk: "Re: [PATCH] rename "---help---" to "help" in Kconfig files"
Reply: Adrian Bunk: "Re: [PATCH] rename "---help---" to "help" in Kconfig files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Date:	Thu, 21 Apr 2005 00:06:11 +0200 (CEST)
To: linux-kernel@vger.kernel.org

Ok, I'll admit right up front that this is probably slightly
controversial, and most certainly slightly silly as well, and my reasons
for doing this may not be the best in the world, but let me try and
explain the reasons for this patch.

What does it do? : It renames all instances of "---help---" to simply
"help" in all of the Kconfig files.

Why does it do this? : There are two reasons for doing this;
1) Consistency. out of ~4000 help entries in 134 Kconfig files, 747 of
those entries use "---help---" as the keyword, the rest use just "help".
So the users of "---help---" are clearly a minority and by renaming them
we make things consistent. - I hate inconsistency. :-)
2) By not using two different "keywords" I assume it will be posible to
speed up kbuilds handling of Kconfig files slightly. That goal is not
accomplished by this patch, but this patch is a prerequisite for making
that change later.

Now I think I can already guess some of the arguments against this;
a) this diff will clutter up the change history for those files. True, it
will, but Kconfig files see releatively few changes so this shouldn't be a
big deal.
b) This doesn't improve anything for the users of the Kconfig files. Again
true, it will not, but if it leads to a slightly faster kbuild that /will/
benefit users if only ever so slightly).

Anyway, I made the patch, if it makes sense to the powers that be, then
feel free to apply it, if not, then don't apply it and the world moves on
:) No need to make a big fuzz about it...

Since this patch is fairly huge (~250Kb) I've not included it inline, but
you can find it at
http://www.linuxtux.org/~juhl/kernel_patches/Kconfig-help-rewrite.patch

Here's the diffstat :

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Gabriel Jägenstedt: "Re: Booting from USB with initrd"

Previous message: Phillip Lougher: "Re: [PATCH] remove some usesless casts"
Next in thread: Adrian Bunk: "Re: [PATCH] rename "---help---" to "help" in Kconfig files"
Reply: Adrian Bunk: "Re: [PATCH] rename "---help---" to "help" in Kconfig files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Relevant Pages

Re: Shouldnt kconfig defaults match recommendations in help text?
... but thank you for the detailed explanation. ... >> be interrested in the reasons why not. ... changing one kconfig default pr patch. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
(Linux-Kernel)
Re: Kernel SCM saga..
... > that could be fixed with a bit of scripting and rsyncing. ... which removes one of the main reasons for wanting ... is to be able to see if a patch I'm about to send conflicts ... send the line "unsubscribe linux-kernel" in ...
(Linux-Kernel)
Re: Coding style: mixed-case
... >>While there may be reasons why mixed case is suboptimal, ... > Certainly I would like to have a go at a patch, but I must say that I do not ... There could be a quite a bit of external code using these interfaces. ... send the line "unsubscribe linux-kernel" in ...
(Linux-Kernel)
Re: [BK PATCH] One strdup() to rule them all
... >> used such performance critical code that the extra check would hurt? ... > There are two reasons while it shouldn't have a NULL check. ... Will you write that patch then or do I have to put it onto my ... send the line "unsubscribe linux-kernel" in ...
(Linux-Kernel)
Re: [2.6 patch] Kconfig: rename "---help---" to "help" in Kconfig files (first p
... >> This patch is the majority of a patch by Jesper Juhl. ... Kconfig files are quite readable due to this indentation even ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
(Linux-Kernel)