[2.6 patch] drivers/char/mwave/3780i.c: cleanups

From: Adrian Bunk (bunk_at_stusta.de)
Date: 04/30/05

  • Next message: Jonathan Corbet: "Re: Updated realtime-preempt documentation"
    Date:	Sat, 30 Apr 2005 22:08:07 +0200
    To: Andrew Morton <akpm@osdl.org>
    
    

    This patch contains the following cleanups:
    - make a needlessly global function static
    - #if 0 the unused global function dsp3780I_ReadGenCfg

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    ---
    This patch was already sent on:
    - 17 Apr 2005
     drivers/char/mwave/3780i.c |    6 ++++--
     drivers/char/mwave/3780i.h |    4 ----
     2 files changed, 4 insertions(+), 6 deletions(-)
    --- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h.old	2005-04-17 18:12:29.000000000 +0200
    +++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h	2005-04-17 18:13:16.000000000 +0200
    @@ -338,10 +338,6 @@
                                        unsigned long ulMsaAddr);
     void dsp3780I_WriteMsaCfg(unsigned short usDspBaseIO,
                               unsigned long ulMsaAddr, unsigned short usValue);
    -void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
    -                          unsigned char ucValue);
    -unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
    -                                  unsigned uIndex);
     int dsp3780I_GetIPCSource(unsigned short usDspBaseIO,
                               unsigned short *pusIPCSource);
     
    --- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c.old	2005-04-17 18:12:49.000000000 +0200
    +++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c	2005-04-17 18:13:33.000000000 +0200
    @@ -107,8 +107,8 @@
     	spin_unlock_irqrestore(&dsp_lock, flags);
     }
     
    -void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
    -                          unsigned char ucValue)
    +static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
    +				 unsigned char ucValue)
     {
     	DSP_ISA_SLAVE_CONTROL rSlaveControl;
     	DSP_ISA_SLAVE_CONTROL rSlaveControl_Save;
    @@ -141,6 +141,7 @@
     
     }
     
    +#if 0
     unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
                                       unsigned uIndex)
     {
    @@ -167,6 +168,7 @@
     
     	return ucValue;
     }
    +#endif  /*  0  */
     
     int dsp3780I_EnableDSP(DSP_3780I_CONFIG_SETTINGS * pSettings,
                            unsigned short *pIrqMap,
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Jonathan Corbet: "Re: Updated realtime-preempt documentation"

    Relevant Pages

    • [2.6 patch] drivers/char/mwave/ : misc cleanups
      ... Please review whether is patch is correct or whether it might conflict ... +static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex, ... +static int SmapiQuerySystemID ...
      (Linux-Kernel)
    • [2.6 patch] drivers/char/mwave/3780i.c: cleanups
      ... unsigned long ulMsaAddr, unsigned short usValue); ... -void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex, ... +static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex, ...
      (Linux-Kernel)