Re: [RFC][PATCH] update SubmittingPatches to clarify attachment policy

From: Geert Uytterhoeven (geert_at_linux-m68k.org)
Date: 05/05/05

  • Next message: David Woodhouse: "Re: [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between" 
    Date:	Thu, 5 May 2005 11:07:05 +0200 (CEST)
To: Rik van Riel <riel@redhat.com>

    On Wed, 4 May 2005, Rik van Riel wrote:
    > On Wed, 4 May 2005, Dave Hansen wrote:
    > > Plus, a plain/text attachment message saved to a file can go
    > > into 'patch' the same way that an inline one can.
    >
    > The problem is replying to an attachment. The reason why having
    > the patch in the main mail body is good is that it gets quoted
    > by the email software and you can easily reply to individual
    > parts of the patch.

    Indeed. `perfect' patches as attachments are fine. Maybe that's why some people
    testified they never got complaints about their attached patches :-)

    But as soon as you have to point out some comments, replying takes a lot more
    time (save attachment, load it in editor, prepend every line with `> ', ...),
    and may lead to maintainer burn-out.

    Gr{oetje,eeting}s,

                                                    Geert 

    --
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: David Woodhouse: "Re: [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between"

    Relevant Pages

    • SUCCESS Re: 2.6.0-test11-mm1
      ... patch that's responsible, but it'd take a month to find out anything ... conclusive -- ten reboots, two days of stress testing each in order to ... I've stored a Bitkeeper archive of the -mm1 patches (one changeset per ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC] HOWTO do Linux kernel development
      ... IMHO it's ok to submit patches that are not perfect, ... > Justify your change ... My request is that each patch should carry a meaningful changelog. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: page fault scalability patch V12 [0/7]: Overview and performance tests
      ... >>my patch to remove the ptl from the other types of faults as well? ... > I can try that but I am frankly a bit sceptical since the ptl protects ... I wouldn't mind your patches going in. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] [0/2] acpiphp extension for 2.6.7 (final)
      ... what it is -- a patch to acpiphp that allows other modules to register ... These patches were made against the ... kernel tree. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: FAT statfs loop abort on read-error
      ... FAT partition with removed media (without this would hang for minutes). ... unfortunately those patches was ignored. ... one large patch may not be applied. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)