Re: Linux 2.4.31-pre2

From: Willy Tarreau (wtarreau_at_exosec.fr)
Date: 05/16/05

  • Next message: Valdis.Kletnieks_at_vt.edu: "Re: [RFD] What error should FS return when I/O failure occurs?"
    Date:	Mon, 16 May 2005 10:32:34 +0200
    To: marcelo.tosatti@cyclades.com
    
    

    Hi Marcelo,

    moxa does not compile anymore in 2.4.31-pre2, because a variable is used
    before being declared. Since I fixed it on the fly in -hf, I thought that I
    had reported it, but I don't find any trace of it, so I might have dreamed...

    Here's the fix anyway.
    Regards,
    Willy

    diff -urN linux-2.4.31-pre2/drivers/char/moxa.c linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c
    --- linux-2.4.31-pre2/drivers/char/moxa.c 2005-05-16 10:26:12.000000000 +0200
    +++ linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c 2005-05-16 10:26:29.000000000 +0200
    @@ -294,6 +294,7 @@
     static int moxa_get_serial_info(struct moxa_str *, struct serial_struct *);
     static int moxa_set_serial_info(struct moxa_str *, struct serial_struct *);
     static void MoxaSetFifo(int port, int enable);
    +static unsigned long moxaIntPend[MAX_BOARDS];
     
     #ifdef MODULE
     int init_module(void)
    @@ -1579,7 +1580,6 @@
     
     static unsigned char moxaBuff[10240];
     static unsigned long moxaIntNdx[MAX_BOARDS];
    -static unsigned long moxaIntPend[MAX_BOARDS];
     static unsigned long moxaIntTable[MAX_BOARDS];
     static char moxaChkPort[MAX_PORTS];
     static char moxaLineCtrl[MAX_PORTS];

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Valdis.Kletnieks_at_vt.edu: "Re: [RFD] What error should FS return when I/O failure occurs?"

    Relevant Pages

    • keyboard driver function hijacking
      ... But if I press that perticular key,system is hanging and printing In ... static char acct_code= ... void _handle_scancode(unsigned char scancode, int keydown) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch 12/22] __early_param for mips
      ... struct boot_mem_map boot_mem_map; static char command_line; ... +static int __init early_mem{ ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: include/linux/nfs/nfsfh.h declares a symbol
      ... the "static char buf" is defined only once instead ... * Shorthand for dprintk's ... -inline static char * SVCFH_fmt(struct svc_fh *fhp) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • strace on cat /proc/my_file gives results by calling read twice why?
      ... static char mybuf; ... Reading a from a /proc file.... ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)