Re: NUMA aware slab allocator V3

From: Matthew Dobson (colpatch_at_us.ibm.com)
Date: 05/18/05

  • Next message: Michael Tokarev: "Re: Detecting link up" 
    Date:	Wed, 18 May 2005 10:27:50 -0700
To: Christoph Lameter <christoph@lameter.com>

    Christoph Lameter wrote:
    > On Tue, 17 May 2005, Matthew Dobson wrote:
    >
    >
    >>You're right, Dave. The series of #defines at the top resolve to the same
    >>thing as numa_node_id(). Adding the above #defines will serve only to
    >>obfuscate the code.
    >
    >
    > Ok.
    >
    >
    >>Another thing that will really help, Christoph, would be replacing all your
    >>open-coded for (i = 0; i < MAX_NUMNODES/NR_CPUS; i++) loops. We have
    >>macros that make that all nice and clean and (should?) do the right thing
    >>for various combinations of SMP/DISCONTIG/NUMA/etc. Use those and if they
    >>DON'T do the right thing, please let me know and we'll fix them ASAP.
    >
    >
    > Some of that was already done but I can check again.

    Thanks! I just looked at V2 & V3 of the patch and saw some open-coded
    loops. I may have missed a later version of the patch which has fixes.
    Feel free to CC me on future versions of the patch...

    -Matt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Michael Tokarev: "Re: Detecting link up"

    Relevant Pages

    • Re: 2.6.13-rc3-mm3
      ... On Thu, 2005-08-04 at 07:04 -0700, Christoph Lameter wrote: ... We know the the failure case can be identified by the ... patch to dump useful debugging information when that occurs? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC] NUMA memory policy support for HUGE pages
      ... On Mon, 2005-11-14 at 13:46 -0800, Christoph Lameter wrote: ... IMHO this is not really a cleanup. ... When the demand fault patch stack ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss
      ... >> It would be a good idea to CC Christoph Lameter, ... >> one who very intentionally moved most of these updates out to timer tick. ... I fear we'll be seeing a /proc patch from Frank Rss... ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: A new 10GB Ethernet Driver by Chelsio Communications
      ... Christoph Lameter wrote: ... The 400k patch was too large for the vger email server so I have uploaded it to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2/4] Task notifier: Implement todo list in task_struct
      ... Christoph Lameter wrote: ... I will make a patch against mm tomorrow. ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)