Re: [PATCH] prevent NULL mmap in topdown model
From: Arjan van de Ven (arjan_at_infradead.org)
Date: 05/19/05
- Previous message: Salomon, Frank: "Re: pci-irq VIA82C586 problem on IBM 4694-205 kernel version 2.4.29"
- In reply to: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Next in thread: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Reply: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Reply: Greg Stark: "Re: [PATCH] prevent NULL mmap in topdown model"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Chris Wright <chrisw@osdl.org> Date: Thu, 19 May 2005 10:15:10 +0200
On Wed, 2005-05-18 at 23:46 -0700, Chris Wright wrote:
> * Linus Torvalds (torvalds@osdl.org) wrote:
> > However, it would be good to have even the trivial patch tested.
> > Especially since what it tries to fix is a total corner-case in the first
> > place..
>
> I gave it a quick and simple test. Worked as expected. Last page got
> mapped at 0x1000, leaving first page unmapped. Of course, either with
> MAP_FIXED or w/out MAP_FIXED but proper hint (like -1) you can still
> map first page. This isn't to say I was extra creative in testing.
sure. Making it *impossible* to mmap that page is bad. People should be
able to do that if they really want to, just doing it if they don't ask
for it is bad.
There are plenty of reasons people may want that page mmaped, one of
them being that the compiler can then do more speculative loads around
null pointer checks. Not saying it's a brilliant idea always, but making
such things impossible makes no sense.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Salomon, Frank: "Re: pci-irq VIA82C586 problem on IBM 4694-205 kernel version 2.4.29"
- In reply to: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Next in thread: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Reply: Chris Wright: "Re: [PATCH] prevent NULL mmap in topdown model"
- Reply: Greg Stark: "Re: [PATCH] prevent NULL mmap in topdown model"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
