Re: [CRYPTO]: Only reschedule if !in_atomic()
From: Herbert Xu (herbert_at_gondor.apana.org.au)
Date: 05/24/05
- Previous message: Jeff Garzik: "Re: enable-reads-on-plextor-712-sa-on-26115.patch added to -mm tree"
- Maybe in reply to: Andrew Morton: "Re: [CRYPTO]: Only reschedule if !in_atomic()"
- Next in thread: Arjan van de Ven: "Re: [CRYPTO]: Only reschedule if !in_atomic()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 24 May 2005 13:47:44 +1000 To: "David S. Miller" <davem@davemloft.net>
On Mon, May 23, 2005 at 07:36:12PM -0700, David S. Miller wrote:
>
> See how ugly this stuff gets once you start letting some people call
> this stuff with locks and some not?
But we already do that anyway. For example, IPsec calls the crypto
functions with a spin lock on the xfrm_state. As it is, you're
allowed to call crypto functions while holding spin locks if and
only if you're in softirq context.
Incidentally, that is something I intend on changing. There is no
reason why we can't do away with that spin lock on the fast path
for IPsec.
> Crypto operations, especially the software operations, are extremely
> expensive compute bound tasks. It is very desirable, as a result, for
> them to be allowed to relinquish the cpu from time to time.
Agreed.
> That being said, I guess a flag isn't so bad.
The other thing we could do with a flag is to use it to set GFP
flags for memory allocation.
Cheers,
-- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jeff Garzik: "Re: enable-reads-on-plextor-712-sa-on-26115.patch added to -mm tree"
- Maybe in reply to: Andrew Morton: "Re: [CRYPTO]: Only reschedule if !in_atomic()"
- Next in thread: Arjan van de Ven: "Re: [CRYPTO]: Only reschedule if !in_atomic()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
