Re: [patch] remove set_tsk_need_resched() from init_idle()
From: Nick Piggin (nickpiggin_at_yahoo.com.au)
Date: 05/24/05
- Previous message: Rajesh Shah: "Re: [patch 2/2] x86_64: Collect host bridge resources"
- Maybe in reply to: Ingo Molnar: "[patch] remove set_tsk_need_resched() from init_idle()"
- Next in thread: Andrew Morton: "Re: [patch] remove set_tsk_need_resched() from init_idle()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 25 May 2005 02:00:00 +1000 To: Ingo Molnar <mingo@elte.hu>
Ingo Molnar wrote:
> --
>
> this patch (ontop of the current -mm scheduler patchset) tweaks
> cpu_idle() semantics a bit: it changes the idle loops (that do
> preemption) to call the first schedule() unconditionally.
>
> the advantage is that as a result we dont have to set the idle thread's
> NEED_RESCHED flag in init_idle(), which in turn makes cond_resched()
> even more of an invariant: it can be called even from init code without
> it having any effect. A cond resched in the init codepath hangs
> otherwise.
>
> this patch, while having no negative side-effects, enables wider use of
> cond_resched()s. (which might happen in the stock kernel too, but it's
> particulary important for voluntary-preempt) (note that for now this
> patch only covers architectures that use kernel/Kconfig.preempt, but all
> other architectures will work just fine too.)
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
Looks fine.
Acked-by: Nick Piggin <nickpiggin@yahoo.com.au>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Rajesh Shah: "Re: [patch 2/2] x86_64: Collect host bridge resources"
- Maybe in reply to: Ingo Molnar: "[patch] remove set_tsk_need_resched() from init_idle()"
- Next in thread: Andrew Morton: "Re: [patch] remove set_tsk_need_resched() from init_idle()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
