Re: [2.6 patch] drivers/ide/: possible cleanups
From: Adrian Bunk (bunk_at_stusta.de)
Date: 05/30/05
- Previous message: Goffredo Baroncelli: "[TRIVIAL][PATCH] UDF filesystem: array '__mon_yday' declared as not static"
- In reply to: Benjamin Herrenschmidt: "Re: [2.6 patch] drivers/ide/: possible cleanups"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 30 May 2005 23:57:33 +0200 To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
On Tue, May 31, 2005 at 07:44:36AM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - pci/cy82c693.c: make a needlessly global function static
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - ide-taskfile.c: do_rw_taskfile
> > - ide-iops.c: default_hwif_iops
> > - ide-iops.c: default_hwif_transport
> > - ide-iops.c: wait_for_ready
>
> Are we sure we want to do that ? That would mean never having IDE host
> controller drivers as modules...
>
> I was thinking about toying with that again for pmac one of these
> days ...
>
> It may be worth, however, to rename those exported symbols to ide_*
My patch only removes the EXPORT_SYMBOL's.
It's always trivial to re-add them when you need them.
> Ben.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Goffredo Baroncelli: "[TRIVIAL][PATCH] UDF filesystem: array '__mon_yday' declared as not static"
- In reply to: Benjamin Herrenschmidt: "Re: [2.6 patch] drivers/ide/: possible cleanups"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
