Re: pcdp-build-fix.patch added to -mm tree

From: Alexey Dobriyan (adobriyan_at_gmail.com)
Date: 05/31/05

  • Next message: Gene Heskett: "Re: [patch] Real-Time Preemption, -RT-2.6.12-rc5-V0.7.47-15" 
    To: akpm@osdl.org
Date:	Tue, 31 May 2005 20:22:44 +0400

    On Tuesday 31 May 2005 13:24, akpm@osdl.org wrote:
    > --- 25/drivers/firmware/pcdp.c~pcdp-build-fix
    > +++ 25-akpm/drivers/firmware/pcdp.c
    > @@ -11,6 +11,7 @@
    > * published by the Free Software Foundation.
    > */
    >
    > +#include <linux/config.h>
    > #include <linux/acpi.h>

    Does this patch make sense?
    ===========================
    Recent restoration of quirk_via_irqpic() #ifdef'fed whole include/linux/acpi.h
    with CONFIG_ACPI. So, if acpi.h is unlucky enough to be included before
    config.h, bad things happen:

                    [tested, patch fixes the warning]

            drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
            drivers/serial/8250_acpi.c:51: warning: implicit declaration of
            function `acpi_register_gsi'

    or even

                    [untested]

            In file included from drivers/firmware/pcdp.c:18:
            drivers/firmware/pcdp.h:48: error: field 'addr' has incomplete type

    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

    --- linux-vanilla/include/linux/acpi.h 2005-05-28 02:59:59.000000000 +0400
    +++ linux-8250/include/linux/acpi.h 2005-05-28 03:39:25.000000000 +0400
    @@ -25,6 +25,8 @@
     #ifndef _LINUX_ACPI_H
     #define _LINUX_ACPI_H
     
    +#include <linux/config.h>
    +
     #ifdef CONFIG_ACPI
     
     #ifndef _LINUX
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Gene Heskett: "Re: [patch] Real-Time Preemption, -RT-2.6.12-rc5-V0.7.47-15"

    Relevant Pages

    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.0-test8/test9 io scheduler needs tuning?
      ... interactivity with regard to desktop use. ... Going to improve the time info output of the ddd loops to get better data and ... with the patch the hang reported earlier was not encountered again so ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
      ... > For VISWS I think you actually need to turn paging off explicitly. ... The patch will need a few tweaks but it should be fairly straight forward. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] clarify message and give support contact for non-GPL modules
      ... The author of the second module ... So here is another attempt at the patch. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)