Re: [patch 6/9] dlm: clear recovery flags

From: Arjan van de Ven (arjan_at_infradead.org)
Date: 06/02/05

  • Next message: Tilo Lutz: "IRQ problems with 915gm chipset"
    To: David Teigland <teigland@redhat.com>
    Date:	Thu, 02 Jun 2005 10:19:20 +0200
    
    

    On Thu, 2005-06-02 at 16:03 +0800, David Teigland wrote:
    > plain text document attachment (clear-recovery-flags.patch)
    > At the start of recovery, all the recovery flags are cleared from the
    > previous recovery. Two of them weren't being cleared.
    >
    > Signed-off-by: David Teigland <teigland@redhat.com>
    >
    > Index: linux/drivers/dlm/member.c
    > ===================================================================
    > --- linux.orig/drivers/dlm/member.c 2005-06-02 12:28:30.000000000 +0800
    > +++ linux/drivers/dlm/member.c 2005-06-02 13:07:46.060566696 +0800
    > @@ -276,6 +276,8 @@
    > */
    >
    > dlm_recoverd_suspend(ls);
    > + clear_bit(LSFL_LOCKS_VALID, &ls->ls_flags);
    > + clear_bit(LSFL_ALL_LOCKS_VALID, &ls->ls_flags);
    > clear_bit(LSFL_DIR_VALID, &ls->ls_flags);
    > clear_bit(LSFL_ALL_DIR_VALID, &ls->ls_flags);
    > clear_bit(LSFL_NODES_VALID, &ls->ls_flags);

    btw do these need to be atomic? right now these are atomic ops and thus
    very expensive... you might want to switch to nonatomic variants if
    that's not needed.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Tilo Lutz: "IRQ problems with 915gm chipset"

    Relevant Pages

    • Re: Desktop Filesystem Benchmarks in 2.6.3
      ... >understand the implications of recovery, ... You can buy cables that allow you to connect laptop drives to desktops. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Handle non-readable binfmt_misc executables
      ... > uses sys_close for recovery in case of error. ... loaders that haven't been converted to the firmware loading framework). ... precautions shouldn/t be needed ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: [PATCH] Handle non-readable binfmt_misc executables
      ... uses sys_close for recovery in case of error. ... Performance Tools Lab ... >To: Linux Kernel Mailing List ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC&PATCH 1/2] PCI Error Recovery (readX_check)
      ... > This is the latest patch for PCI recovery. ... what you are doing will be useful for existing 2.6 kernels ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Desktop Filesystem Benchmarks in 2.6.3
      ... >> but I lost all data on one of my volumes due to a bad block on my hard ... XFS was unable to recover from the error, and the XFS recovery ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)