RE: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Abhay_Salunke_at_Dell.com
Date: 06/17/05

  • Next message: Richard B. Johnson: "Re: Kernel eats argument=" 
    Date:	Fri, 17 Jun 2005 09:55:31 -0500
To: <greg@kroah.com>

    > -----Original Message-----
    > From: Greg KH [mailto:greg@kroah.com]
    > Sent: Thursday, June 16, 2005 1:52 PM
    > To: Salunke, Abhay
    > Cc: linux-kernel@vger.kernel.org; Andrew Morton; Dmitry Torokhov;
    Domsch,
    > Matt
    > Subject: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new
    Dell
    > BIOS update driver
    >
    > On Wed, Jun 15, 2005 at 12:59:46PM -0500, Abhay Salunke wrote:
    > > +static struct device rbu_device_mono;
    > > +static struct device rbu_device_packet;
    > > +static struct device rbu_device_cancel;
    >
    > You should never create a struct device on the stack. Lots of bad
    > things can happen (including not having a release function for them.)
    >
    they are not declared inside any function; can they be on stack?
    > Why not just point to the cpu device, or some other platform or system
    > device?
    >
    Not sure what these devices are for and didn't want to mess with them.>

    Thanks
    Abhay
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Richard B. Johnson: "Re: Kernel eats argument="

    Relevant Pages

    • Re: [Bug 2773] New: kernel panic under medium load
      ... Now, that would look like a pointer that _should_ be zero, but with a ... possibly due to a stack overflow that just overwrote the thread-info (and ... > Controller ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rcX cdrom.c is subject to "chaotic" behaviour
      ... The culprit is newly ... while the offsetof on the other hand is ... >> which in turn results in random values from the stack being evaluated ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC] cleanup patches for strings
      ... larger, slower, and uses more stack. ... If the array is declared const makes ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] i386: always use 4k stacks
      ... > today on an older Niksun box running off the end of the stack. ... Check the compaq drivers for SATA as well, ... Jeff ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: XFS over 7.7TB LVM partition through NFS
      ... And, that stack looks awfully long if it's real, turning on the stack ... > over NFS. ... After exporting the filesystem clients start writing files to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)