Re: [DVB patch 21/51] ttusb-dec: kfree cleanup
From: Johannes Stezenbach (js_at_linuxtv.org)
Date: 06/28/05
- Previous message: christoph: "Re: [PATCH] Move some variables into the "most_readonly" section??"
- In reply to: Andrew Morton: "Re: [DVB patch 21/51] ttusb-dec: kfree cleanup"
- Next in thread: Johannes Stezenbach: "[DVB patch 14/51] DVB update"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 28 Jun 2005 01:20:27 +0200 To: Andrew Morton <akpm@osdl.org>
Andrew Morton wrote:
> Johannes Stezenbach <js@linuxtv.org> wrote:
> >
> > From: Adrian Bunk <bunk@stusta.de>
> >
> > The Coverity checker discovered that these two kfree's can never be
> > executed.
> >
>
> That's a bit strange - the code was OK beforehand. It's a bit of a tossup.
Hm, the comment was a bit misleading, but the kfree(NULL) is a no-op.
> > /* allocate memory for the internal state */
> > state = (struct ttusbdecfe_state*) kmalloc(sizeof(struct ttusbdecfe_state), GFP_KERNEL);
>
> This typecast is unneeded btw. We tend to avoid casts to and from void*
> because they defeat typechecking and uglify things.
I just passed the patch on unchanged. The void-cast cleanup is for
another patch (the issue is known and we already cleaned up quite
a lot of them).
Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: christoph: "Re: [PATCH] Move some variables into the "most_readonly" section??"
- In reply to: Andrew Morton: "Re: [DVB patch 21/51] ttusb-dec: kfree cleanup"
- Next in thread: Johannes Stezenbach: "[DVB patch 14/51] DVB update"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
