Re: [PATCH] deinline sleep/delay functions

From: Arjan van de Ven (arjan_at_infradead.org)
Date: 06/30/05

  • Next message: Greg KH: "[RFC] PCI: clean up the dynamic pci id logic" 
    To: Andrew Morton <akpm@osdl.org>
Date:	Thu, 30 Jun 2005 11:19:48 +0200

    > > There are a number of compile-time checks that your patch has removed
    > > which catch such things, and as such your patch is not acceptable.
    > > Some architectures have a lower threshold of acceptability for the
    > > maximum udelay value, so it's absolutely necessary to keep this.
    >
    > It removes that check from x86 - other architectures retain it.
    >
    > I don't recall seeing anyone trigger the check,

    I do ;) Esp in vendor out of tree crap. It's a good compile time
    diagnostic so the junk code doesnt' hit mainline but gets fixed first.

    >
    > and it hardly seems worth
    > adding a "few kb" to vmlinux for it?

    but it can be fixed to not add that few kb while retaining the checking
    value. All that needs is for it to be a define that calls the worker
    function. Eg the check gets optimized out and all that remains is the
    call to the worker function that does the actual delay.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg KH: "[RFC] PCI: clean up the dynamic pci id logic"