[PATCH] vfree cleanup for sound/oss/sb_card.c

From: Jesper Juhl (juhl-lkml_at_dif.dk)
Date: 06/30/05

  • Next message: matthieu castet: "Re: device_remove_file and disconnect"
    Date:	Thu, 30 Jun 2005 22:34:45 +0200 (CEST)
    To: linux-kernel <linux-kernel@vger.kernel.org>
    
    

    vfree can take a NULL pointer, no point in checking.

    Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

    ---
     sound/oss/sb_card.c |    6 ++----
     1 files changed, 2 insertions(+), 4 deletions(-)
    --- linux-2.6.13-rc1-orig/sound/oss/sb_card.c	2005-06-17 21:48:29.000000000 +0200
    +++ linux-2.6.13-rc1/sound/oss/sb_card.c	2005-06-30 22:29:46.000000000 +0200
    @@ -337,10 +337,8 @@ static void __exit sb_exit(void)
     	pnp_unregister_card_driver(&sb_pnp_driver);
     #endif
     
    -	if (smw_free) {
    -		vfree(smw_free);
    -		smw_free = NULL;
    -	}
    +	vfree(smw_free);
    +	smw_free = NULL;
     }
     
     module_init(sb_init);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: matthieu castet: "Re: device_remove_file and disconnect"

    Relevant Pages

    • [PATCH 2/3] 2.6 ISDN Eicon driver: vfree()
      ... Removed check for NULL pointer before doing vfree(), ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [PATCH] shrink inode when quota is disabled
      ... drop quota array in inode struct if no quota support ... +#ifdef CONFIG_QUOTA ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [PATCH][2.6.7-mm4] perfctr update 1/6: fix linkage error
      ... static void __init do_rdpmc(unsigned pmc, unsigned unused2) ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch 2/8] s390: vfree checking cleanup.
      ... arch/s390/kernel/module.c vfree() checking cleanup. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [-mm patch] arch/i386/kernel/traps.c: fix SYSFS=n compile
      ... : undefined reference to `last_sysfs_file' ... +#ifdef CONFIG_SYSFS ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)