[PATCH] vfree cleanup for sound/oss/sb_card.c

From: Jesper Juhl (juhl-lkml_at_dif.dk)
Date: 06/30/05

  • Next message: matthieu castet: "Re: device_remove_file and disconnect"
    Date:	Thu, 30 Jun 2005 22:34:45 +0200 (CEST)
    To: linux-kernel <linux-kernel@vger.kernel.org>
    
    

    vfree can take a NULL pointer, no point in checking.

    Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

    ---
     sound/oss/sb_card.c |    6 ++----
     1 files changed, 2 insertions(+), 4 deletions(-)
    --- linux-2.6.13-rc1-orig/sound/oss/sb_card.c	2005-06-17 21:48:29.000000000 +0200
    +++ linux-2.6.13-rc1/sound/oss/sb_card.c	2005-06-30 22:29:46.000000000 +0200
    @@ -337,10 +337,8 @@ static void __exit sb_exit(void)
     	pnp_unregister_card_driver(&sb_pnp_driver);
     #endif
     
    -	if (smw_free) {
    -		vfree(smw_free);
    -		smw_free = NULL;
    -	}
    +	vfree(smw_free);
    +	smw_free = NULL;
     }
     
     module_init(sb_init);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: matthieu castet: "Re: device_remove_file and disconnect"

    Relevant Pages

    • [PATCH 2/3] 2.6 ISDN Eicon driver: vfree()
      ... Removed check for NULL pointer before doing vfree(), ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: Vim tip (was Re: Suspend/Resume issues - Custom scripts notrunning? Mouse frozen?)
      ... au BufWritePost * call ModeChange() ... " date/times of actual directory holding the filebeing edited ... subject of "unsubscribe". ...
      (Debian-User)
    • Re: Screen Lock & Locate Pointer
      ... I not sure if this is a bug or not, but when I activate the the ... Control key to show the position of were the mouse pointer is on the ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • Screen Lock & Locate Pointer
      ... Control key to show the position of were the mouse pointer is on the ... I have noticed that when this is activated the Lock Screen ... the 'Locate Pointer' key binding but that seems to be hard coded some ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)
    • X has lost Ctrl+Alt+Keypad-Plus/Minus
      ... It's still possible to switch modes with gvidm but if you move the ... the view port would scroll to follow the pointer. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx ...
      (Debian-User)