Re: Linux 2.6.13-rc2

From: Greg KH (greg_at_kroah.com)
Date: 07/06/05

  • Next message: Greg KH: "Re: [PATCH] char: Add Dell Systems Management Base driver"
    Date:	Wed, 6 Jul 2005 08:51:03 -0700
    To: Linus Torvalds <torvalds@osdl.org>
    
    

    On Wed, Jul 06, 2005 at 08:42:16AM -0700, Linus Torvalds wrote:
    >
    >
    > On Wed, 6 Jul 2005, Eyal Lebedinsky wrote:
    > >
    > > CC [M] sound/pci/bt87x.o
    > > sound/pci/bt87x.c: In function `snd_bt87x_detect_card':
    > > sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this function)
    > > sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported only once
    > > sound/pci/bt87x.c:807: error: for each function it appears in.)
    > > sound/pci/bt87x.c: At top level:
    > > sound/pci/bt87x.c:910: error: `driver' used prior to declaration
    >
    > This seems to be a thinko by Greg. That line got changed from
    >
    > supported = pci_match_device(snd_bt87x_ids, pci);
    >
    > to
    >
    > supported = pci_match_device(driver, pci);
    >
    > but as far as I can tell it _should_ be
    >
    > supported = pci_match_id(snd_bt87x_ids, pci);

    No, I wanted it to be "driver", but forgot to build the code, sorry.
    Try the following patch instead:

    thanks,

    greg k-h

    -------------------

    Fixes bt87x.c build problem.

    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
     sound/pci/bt87x.c |    2 ++
     1 files changed, 2 insertions(+)
    --- gregkh-2.6.orig/sound/pci/bt87x.c	2005-07-06 08:48:29.000000000 -0700
    +++ gregkh-2.6/sound/pci/bt87x.c	2005-07-06 08:48:54.000000000 -0700
    @@ -798,6 +798,8 @@
     	{0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */
     };
     
    +static struct pci_driver driver;
    +
     /* return the rate of the card, or a negative value if it's blacklisted */
     static int __devinit snd_bt87x_detect_card(struct pci_dev *pci)
     {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Greg KH: "Re: [PATCH] char: Add Dell Systems Management Base driver"

    Relevant Pages

    • Re: SysFS, module names and .name
      ... Greg KH wrote: ... I would know which driver name corresponds to ... > changing every single pci driver to enable it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: small patch: enable pwc usb camera driver
      ... > Greg KH wrote: ... Ick ick ick! ... time to mark the driver broken again... ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2/4] Driver core: add driver_probe_device
      ... I really like the "driver" part in the device. ... (will be a few hours, have real work to do for a bit, sorry...) ... greg k-h ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [linux-usb-devel] Re: Finding user/kernel pointer bugs [no html]
      ... Greg KH wrote: ... the driver you just refered to does not use the video_usercopy ... However, apart from the "__user" context, there are several drivers ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2/4] Driver core: add driver_probe_device
      ... On Friday 29 October 2004 11:37 am, Greg KH wrote: ... What about "bind_mode" device and driver attributes? ... then I need to check these attributes in serio's bus match function, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)