Re: 2.6.12.2 -- time passes faster; related to the acpi_register_gsi() call

From: Alexander Nyberg (alexn_at_telia.com)
Date: 07/08/05

  • Next message: Ingo Molnar: "Re: Realtime Preemption, 2.6.12, Beginners Guide?"
    To: Rudo Thomas <rudo@matfyz.cz>
    Date:	Fri, 08 Jul 2005 23:25:08 +0200
    
    

    fre 2005-07-08 klockan 23:12 +0200 skrev Rudo Thomas:
    > Hello, guys.
    >
    > Time started to pass faster with 2.6.12.2 (actually, it was 2.6.12-ck3
    > which is based on it). I have isolated the cause of the problem:

    I bet you this fixes it (already in mainline)

    tree e6a38b3d6bf434f08054562113bb660c4227769f
    parent 4a89a04f1ee21a7c1f4413f1ad7dcfac50ff9b63
    author Linus Torvalds <torvalds@g5.osdl.org> Sun, 03 Jul 2005 00:35:33 -0700
    committer Linus Torvalds <torvalds@g5.osdl.org> Sun, 03 Jul 2005 00:35:33 -0700

    If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.

    That zero just means that nothing else found any irq information either.

     drivers/acpi/pci_irq.c | 2 +-
     1 files changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
    --- a/drivers/acpi/pci_irq.c
    +++ b/drivers/acpi/pci_irq.c
    @@ -433,7 +433,7 @@ acpi_pci_irq_enable (
                     printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
                             pci_name(dev), ('A' + pin));
                     /* Interrupt Line values above 0xF are forbidden */
    - if (dev->irq >= 0 && (dev->irq <= 0xF)) {
    + if (dev->irq > 0 && (dev->irq <= 0xF)) {
                             printk(" - using IRQ %d\n", dev->irq);
                             acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
                             return_VALUE(0);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Ingo Molnar: "Re: Realtime Preemption, 2.6.12, Beginners Guide?"

    Relevant Pages

    • Re: SL811 problem on mach-pxa
      ... It was tested with _both_ workarounds for IRQ issues; ... unlike the predecessors to this driver). ... I've had reports that one of the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] smsc-ircc2: Add PnP support.
      ... you must have 2 io entries, 1 dma entry and an irq ... A laptop of the friend have wrong pnpbios entries... ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PREEMPT_RT vs I-PIPE: the numbers, part 2
      ... > irq latency test you wont hear a complaint from me. ... > there will be noticeable overhead. ... I checked some of the lmbench numbers ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • MORE THAN 10 IDE CONTROLLERS
      ... ide3 at 0xdfa0-0xdfa7,0xdfaa on irq 23 ... i guess i need to patch major and minor numbers for the devices as well ... Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Serial driver hangs
      ... drop RTS (like driver throttle method) when disabling ... reenabling the IRQ. ... > is the exact reason of locking the filp buffer with the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)