[PATCH] I2C: Coding style cleanups to via686a

From: Greg KH (gregkh_at_suse.de)
Date: 07/12/05

  • Next message: Chris Friesen: "Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt"
    Date:	Mon, 11 Jul 2005 15:02:56 -0700
    To: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
    
    

    [PATCH] I2C: Coding style cleanups to via686a

    On Wednesday 22 June 2005 08:17, Greg KH wrote:
    > [PATCH] I2C: Coding style cleanups to via686a
    >
    > The via686a hardware monitoring driver has infamous coding style at the
    > moment. I'd like to clean up the mess before I start working on other
    > changes to this driver. Is the following patch acceptable? No code
    > change, only coding style (indentation, alignments, trailing white
    > space, a few parentheses and a typo).
    >
    > Signed-off-by: Jean Delvare <khali@linux-fr.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    Nice.

    You missed some. This one is on top of your patch:

    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    commit 6328c0e163abfce679b1beffb166f72900bf0a22
    tree d5fa7087c5d18b12bd1b93797de2277bddcb6300
    parent 200d481f28be4522464bb849dd0eb5f8cb6be781
    author Denis Vlasenko <vda@ilport.com.ua> Wed, 22 Jun 2005 10:25:13 +0300
    committer Greg Kroah-Hartman <gregkh@suse.de> Mon, 11 Jul 2005 14:10:36 -0700
     drivers/i2c/chips/via686a.c |   12 ++++++------
     1 files changed, 6 insertions(+), 6 deletions(-)
    diff --git a/drivers/i2c/chips/via686a.c b/drivers/i2c/chips/via686a.c
    --- a/drivers/i2c/chips/via686a.c
    +++ b/drivers/i2c/chips/via686a.c
    @@ -1,9 +1,9 @@
     /*
         via686a.c - Part of lm_sensors, Linux kernel modules
    -                for hardware monitoring
    +		for hardware monitoring
     
         Copyright (c) 1998 - 2002  Frodo Looijaard <frodol@dds.nl>,
    -                        Kyösti Mälkki <kmalkki@cc.hut.fi>,
    +			Kyösti Mälkki <kmalkki@cc.hut.fi>,
     			Mark Studebaker <mdsxyz123@yahoo.com>,
     			and Bob Dougherty <bobd@stanford.edu>
         (Some conversion-factor data were contributed by Jonathan Teh Soon Yew
    @@ -171,18 +171,18 @@ static inline u8 FAN_TO_REG(long rpm, in
     /******** TEMP CONVERSIONS (Bob Dougherty) *********/
     /* linear fits from HWMon.cpp (Copyright 1998-2000 Jonathan Teh Soon Yew)
           if(temp<169)
    -              return double(temp)*0.427-32.08;
    +	      return double(temp)*0.427-32.08;
           else if(temp>=169 && temp<=202)
    -              return double(temp)*0.582-58.16;
    +	      return double(temp)*0.582-58.16;
           else
    -              return double(temp)*0.924-127.33;
    +	      return double(temp)*0.924-127.33;
     
      A fifth-order polynomial fits the unofficial data (provided by Alex van
      Kaam <darkside@chello.nl>) a bit better.  It also give more reasonable
      numbers on my machine (ie. they agree with what my BIOS tells me).
      Here's the fifth-order fit to the 8-bit data:
      temp = 1.625093e-10*val^5 - 1.001632e-07*val^4 + 2.457653e-05*val^3 -
    -        2.967619e-03*val^2 + 2.175144e-01*val - 7.090067e+0.
    +	2.967619e-03*val^2 + 2.175144e-01*val - 7.090067e+0.
     
      (2000-10-25- RFD: thanks to Uwe Andersen <uandersen@mayah.com> for
      finding my typos in this formula!)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Chris Friesen: "Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt"

    Relevant Pages

    • Re: [PATCH] Poll microoptimizations.
      ... On Fri, 14 Apr 2006, Andrew Morton wrote: ... The patch moves all handling of these ... variables to the function that declares and "owns" them ). ... stops me is that noone can ever agree on the coding style, ...
      (Linux-Kernel)
    • Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)
      ... You were also copied on the patch when it was added to my tree. ... this is the better way to walk through all of the endpoints for a ... documented as 'proper kernel coding style'. ... is incorrect, I'd be happy to hear about reasons why this would be so, ...
      (Linux-Kernel)
    • Re: Patch related with Fork Bobmbing Attack
      ... goto bad_fork_free; ... please run scripts/checkpatch.pl against your patch. ... out numerous problems with the coding style. ...
      (Linux-Kernel)
    • Re: [PATCH 5/5] slab: fix code formatting
      ... > The slab allocator code is inconsistent in coding style and messy. ... I ran Lindent for mm/slab.c and fixed up goofs by hand. ... We've been patching slab.c at over one patch per week for six months. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2)
      ... aic7xxx's coding style would put parenthesis around the returned ... Actually, rather than adding this check to every driver, I would rather do something like the attached patch: create a pci_request_irq, and pass a struct pci_device to it. ... struct resource *res, resource_size_t size, ...
      (Linux-Kernel)