Re: [PATCH/URL] reiserfs: reformat code with Lindent
From: Linus Torvalds (torvalds_at_osdl.org)
Date: 07/13/05
- Previous message: Andreas Dilger: "Re: [2.6 patch] fs/jbd/: possible cleanups"
- In reply to: Jeff Mahoney: "[PATCH/URL] reiserfs: reformat code with Lindent"
- Next in thread: Jeff Mahoney: "Re: [PATCH/URL] reiserfs: reformat code with Lindent"
- Reply: Jeff Mahoney: "Re: [PATCH/URL] reiserfs: reformat code with Lindent"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Tue, 12 Jul 2005 15:49:10 -0700 (PDT) To: Jeff Mahoney <jeffm@suse.com>
On Tue, 12 Jul 2005, Jeff Mahoney wrote:
>
> This patch contains the result of running scripts/Lindent against
> fs/reiserfs/*.c and include/linux/reiserfs_*.h.
That can't be true. It isn't actually following the Lindent rules. It has
that braindamaged "put the type on a separate line" thing for function
declarations, making a "grep" not show the type. That's very much against
the Linux coding style.
So either your "indent" is broken, or you've used something else than
Lindent.
Also, if it's a pure indentation change with no other changes, I'd almost
prefer it as a script, not a patch. That way it's obvious to everybody
that it's just doing indentation.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Andreas Dilger: "Re: [2.6 patch] fs/jbd/: possible cleanups"
- In reply to: Jeff Mahoney: "[PATCH/URL] reiserfs: reformat code with Lindent"
- Next in thread: Jeff Mahoney: "Re: [PATCH/URL] reiserfs: reformat code with Lindent"
- Reply: Jeff Mahoney: "Re: [PATCH/URL] reiserfs: reformat code with Lindent"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
