Re: resuming swsusp twice

From: Stefan Seyfried (seife_at_suse.de)
Date: 07/14/05

  • Next message: ericvh_at_gmail.com: "[PATCH 2.6.13-rc2-mm2 4/7] v9fs: VFS superblock operations and glue (2.0.2)" 
    Date:	Thu, 14 Jul 2005 20:36:15 +0200
To: Andy Isaacson <adi@hexapodia.org>

    Andy Isaacson wrote:

    > Perhaps the image should be more rigorously checked? I'm wishing that
    > it would verify that the header and the image matched, after it finishes

    in your case, the header and the image matched. There was no new image
    on disk. And no new header.

    > reading the image. For example, computing the hash
    >
    > MD5(header || image) (|| denotes "concatenate" in crypto pseudocode.)
    >
    > and storing that hash in a final trailing block. Additionally, of
    > course, as soon as the resume has read the image it should overwrite the
    > header; and the header should include jiffies or something along those

    the header is actually overwritten _prior_ to reading the image back. Or
    it should be, obviously it was not in your casee.

    > lines to ensure that it won't accidentally have the same contents as the
    > previous image's header.
    >
    > The hash doesn't have to be MD5; even a CRC should suffice I think...

    But the failure you have seen now - failure to invalidate the resume
    header - could also happen as long as we do not fix the reason for your
    failure. If we fix it, we don't need additional security nets ;-)

    But i have no idea what went wrong for you, i'll have a look at the code
    but i doubt that i'll find much of interest.

    One thing which would be interesting:
    You don't eventually have multiple swap partitions? 

    -- 
Stefan Seyfried                  \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices      \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \                    -- Leonard Cohen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: ericvh_at_gmail.com: "[PATCH 2.6.13-rc2-mm2 4/7] v9fs: VFS superblock operations and glue (2.0.2)"

    Relevant Pages

    • Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix
      ... > So I rewritten the fix this way: ... I think you'll find that gets into trouble on the header page, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Hidden Hdr/Ftr - using Print Layout - Not white sp prob
      ... If I click OK, I get the Final with markup view and the header and footer are available for editing. ... I decided to test the two pages first to ensure the failure was exhibited. ... After copying various groups of pages with failures and successes, I discovered there was a section break just before the first page of the main body to facilitate changing page numbering from i, ii, iii followed by 1, 2, 3. ...
      (microsoft.public.word.docmanagement)
    • Re: resuming swsusp twice
      ... > But the failure you have seen now - failure to invalidate the resume ... > header - could also happen as long as we do not fix the reason for your ... One root partition, one swap partition, no swap files or anything. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: How is this?
      ... failure to quote. ... I'm using OE out of the box, with no special settings or ... editing of the header. ...
      (microsoft.public.word.newusers)
    • Re: 2.6.2-rc1-mm1
      ... > In my case it is NTFS causing the build failure. ... > 'ntfs2utc': function body not available ... The fix is to remove the `inline' from the declaration in foo.h. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)