Re: revert yenta free_irq on suspend

From: Russell King (rmk+lkml_at_arm.linux.org.uk)
Date: 07/30/05

  • Next message: Ingo Molnar: "Re: [patch] Real-Time Preemption, -RT-2.6.13-rc4-V0.7.52-01" 
    Date:	Sat, 30 Jul 2005 21:54:03 +0100
To: Linus Torvalds <torvalds@osdl.org>

    On Sat, Jul 30, 2005 at 01:36:24PM -0700, Linus Torvalds wrote:
    > On Sat, 30 Jul 2005, Russell King wrote:
    > >
    > > What this probably means is that we need some way to turn off interrupts
    > > from devices on suspend, and on resume, keep them off until drivers
    > > have had a chance to quiesce all devices, turn them back on, and then
    > > do full resume.
    >
    > No, we just need to suspend and resume the interrupt controller properly.
    > Which we had the technology for, and we actually used to do, but for some
    > (incorrect) reason ACPI people thought it should be up to individual
    > drivers.

    I don't think so - I believe one of the problem cases is where you
    have a screaming interrupt caused by an improperly setup device.

    Consider the case where you have a shared interrupt line and you're
    partially through resuming devices, when one unresumed device (setup
    by the BIOS) suddenly starts asserting its interrupt.

    The kernel then disables the source. Unfortunately, that was the IRQ
    for your USB host, which has your USB keyboard and mouse attached. 

    -- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Ingo Molnar: "Re: [patch] Real-Time Preemption, -RT-2.6.13-rc4-V0.7.52-01"

    Relevant Pages

    • Re: b44 needs to reclaim its interrupt after swsusp
      ... > b44 needs to free/reclaim its interrupt across suspend in order to ... This patch makes it work, but I'm not quite sure why its ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: revert yenta free_irq on suspend
      ... revert yenta free_irq on suspend ... >> wrong to revert PCMCIA fix without also fixing ACPI interpretter. ... another properly behaving device on the same interrupt line generates ... it may not be possible to support both APM and ACPI ...
      (Linux-Kernel)
    • Re: [linux-usb-devel] Re: 2.6.13-mm2
      ... interrupts in it's suspend callback"... ... > interrupt in the first place. ... attached the patch that kills the free_irq/request_irqpair in USB. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: netcf forms application timer and power question
      ... still occur (because the interrupt wakes the device), ... which wakes up the device from suspend and then does something. ... microsoft.public.dotnet.framework.compactframework, archive search in ... Paul T. ...
      (microsoft.public.windowsce.embedded)
    • Re: Sleep/resume problem on s3c2440
      ... Do you acknowledge your interrupt when it fires? ... can fire again before entering suspend mode. ... <apellerin AT adeneo DOT adetelgroup DOT com> ...
      (microsoft.public.windowsce.platbuilder)