2.6.13 ub 3/3: death to ub_bd_rq_fn_1

From: Pete Zaitcev (zaitcev_at_redhat.com)
Date: 07/31/05

  • Next message: Francisco Figueiredo Jr.: "Re: "seeing minute plus hangs during boot" - 2.6.12 and 2.6.13"
    Date:	Sat, 30 Jul 2005 22:51:52 -0700
    To: greg@kroah.com
    
    

    When Al Viro saw the ub.c, he observed that it was a proof positive of
    Linus not reading patches anymore: names like fo_ob_ar_ba_2 used to
    cause serious fireworks. In my defence, any good scheme can be pushed
    to the realm of absurd if pushed far enough.

    Signed-off-by: Pete Zaitcev <zaitcev@yahoo.com>

    --- linux-2.6.13-rc4-4seg/drivers/block/ub.c 2005-07-30 22:19:55.000000000 -0700
    +++ linux-2.6.13-rc4-lem/drivers/block/ub.c 2005-07-29 22:42:00.000000000 -0700
    @@ -407,7 +407,7 @@ struct ub_dev {
     /*
      */
     static void ub_cleanup(struct ub_dev *sc);
    -static int ub_bd_rq_fn_1(struct ub_lun *lun, struct request *rq);
    +static int ub_request_fn_1(struct ub_lun *lun, struct request *rq);
     static int ub_cmd_build_block(struct ub_dev *sc, struct ub_lun *lun,
         struct ub_scsi_cmd *cmd, struct request *rq);
     static void ub_scsi_build_block(struct ub_lun *lun,
    @@ -767,20 +768,20 @@ static struct ub_scsi_cmd *ub_cmdq_pop(s
      * The request function is our main entry point
      */
     
    -static void ub_bd_rq_fn(request_queue_t *q)
    +static void ub_request_fn(request_queue_t *q)
     {
             struct ub_lun *lun = q->queuedata;
             struct request *rq;
     
             while ((rq = elv_next_request(q)) != NULL) {
    - if (ub_bd_rq_fn_1(lun, rq) != 0) {
    + if (ub_request_fn_1(lun, rq) != 0) {
                             blk_stop_queue(q);
                             break;
                     }
             }
     }
     
    -static int ub_bd_rq_fn_1(struct ub_lun *lun, struct request *rq)
    +static int ub_request_fn_1(struct ub_lun *lun, struct request *rq)
     {
             struct ub_dev *sc = lun->udev;
             struct ub_scsi_cmd *cmd;
    @@ -2356,7 +2357,7 @@ static int ub_probe_lun(struct ub_dev *s
             disk->driverfs_dev = &sc->intf->dev; /* XXX Many to one ok? */
     
             rc = -ENOMEM;
    - if ((q = blk_init_queue(ub_bd_rq_fn, &sc->lock)) == NULL)
    + if ((q = blk_init_queue(ub_request_fn, &sc->lock)) == NULL)
                     goto err_blkqinit;
     
             disk->queue = q;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Francisco Figueiredo Jr.: "Re: "seeing minute plus hangs during boot" - 2.6.12 and 2.6.13"

    Relevant Pages

    • Re: [PATCH] propogate gfp_t changes further
      ... On Mon, 24 Oct 2005, Al Viro wrote: ... > Linus, maybe I should just send the entire series your way? ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: silent semantic changes with reiser4
      ... Linus, did you get the email in which I answered all the ... You and Viro did not respond to it.... ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: The price of SELinux (CPU)
      ... computers, it's probable that even a 2:1 slowdown would still result in ... I can't speak for Linus' thinking of course, but I have worked in secure ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.8-rc2-mm1: DVB: "errno" undefined
      ... which hopefully won't happen before the affected modules are properly ... fixed, Linus' tree isn't affected. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: post 2.6.7 BK change breaks Java?
      ... > wouldn't expect either Linus or Andrew to have decided to merge an NX ... Linus' tree. ... how do I tell BitKeeper "pull up to revision..."? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)