Re: [patch 2.6.13-rc4] fix get_user_pages bug

From: Nick Piggin (nickpiggin_at_yahoo.com.au)
Date: 08/01/05

  • Next message: Alexander Y. Fomichev: "Re: 2.6.12 hangs on boot" 
    Date:	Mon, 01 Aug 2005 19:27:26 +1000
To: Ingo Molnar <mingo@elte.hu>

    Ingo Molnar wrote:
    > * Nick Piggin <nickpiggin@yahoo.com.au> wrote:

    >>Feedback please, anyone.
    >
    >
    > it looks good to me, but wouldnt it be simpler (in terms of patch and
    > architecture impact) to always retry the follow_page() in
    > get_user_pages(), in case of a minor fault? The sequence of minor faults

    I believe this can break some things. Hugh posted an example
    in his recent post to linux-mm (ptrace setting a breakpoint
    in read-only text). I think? 

    -- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Alexander Y. Fomichev: "Re: 2.6.12 hangs on boot"

    Relevant Pages

    • [patch 0/6] remove PageReserved
      ... Most of the arch code is just reserved memory reporting, ... Hugh has some code which handles this case but he suggested that we ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch 2] mm: speculative get_page
      ... I'm in the process of recovering one of those with an earlier set ... need to be an atomic flag though, so it can be an "impossible" ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch 2.6.13-rc4] fix get_user_pages bug
      ... Please all hack it around as you see fit, ... pass back a special code VM_FAULT_WRITE to say it has done its full job ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch 0/7] lockless pagecache 2
      ... Code clarity and commenting improvement. ... RCU attempt - completely wrong?). ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RT patch acceptance
      ... > I think where we violently disagree is that in your earlier posts you ... If you look at some of my earlier posts, ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)