Re: [PATCH] mmc: Multi-sector writes

From: Pierre Ossman (drzeus-list_at_drzeus.cx)
Date: 08/18/05

  • Next message: Andrew Morton: "Re: [PATCH] mmc: Multi-sector writes"
    Date:	Thu, 18 Aug 2005 07:48:04 +0200
    To: Andrew Morton <akpm@osdl.org>
    
    

    Andrew Morton wrote:

    >The fact that this is enabled under the experimental
    >CONFIG_MMC_BULKTRANSFER seems unfortunate. I mean, if the code works OK
    >then we should just enable it unconditionally, no?
    >
    >
    >

    It was made this way to make Russell more open to it. I have since not
    recieved any more comments from him so I figured I could pass it by you
    instead to get more wide spread testing. The long term goal was removing
    the config and having it on all the time.

    >I'm thinking that it would be better to not have the config option there
    >and then re-add it late in the 2.6.14 cycle if someone reports problems
    >which cannot be fixed. Or at least make it default to 'y' so we get more
    >testing coverage, then remove the config option later. Or something.
    >
    >Thoughts?
    >
    >

    Removing it would be preferable by me. All that #ifdef tends to clutter
    up the code. After som initial problem with a buggy card everything has
    worked flawlesly.

    Rgds
    Pierre

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Andrew Morton: "Re: [PATCH] mmc: Multi-sector writes"

    Relevant Pages

    • Re: [PATCH] disable PREEMPT_BKL per default
      ... that's not a reason to apply your patch that default-disables the ... i'm fine with removing the .config option for 2.6.15. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 2/2] ide: remove obsolete CONFIG_BLK_DEV_ADMA - cleanup arch
      ... Cleans up default config for various archs, removing ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.4.29-rc3
      ... > David Miller: netfilter, sctp, ipvs, etc. ... I though that both the config option and the feature were removed! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] 2.6 workaround for Athlon/Opteron prefetch errata
      ... >> the flood of emails where someone thinks they built ... fixup a config option the user must set, or that all of these should be ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] dont allow users to set CONFIG_BROKEN=y
      ... the menus to look for something matching your hardware is nice, even if that something is marked BROKEN at least you've then found a place to start working on. ... or do you intend to have a bunch of patches that remove BROKEN for a config option so that people can test them during the -rc and then add it back for them all before a real release? ... nobody will be able to test that patch unless they are willing ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)