Re: Why is kmem_bufctl_t different across platforms?

From: Adrian Bunk (bunk_at_stusta.de)
Date: 08/29/05

  • Next message: Jeff Garzik: "[PATCH] change libata license from OSL+GPL to GPL" 
    Date:	Mon, 29 Aug 2005 01:37:16 +0200
To: Andrew Morton <akpm@osdl.org>

    On Sun, Aug 28, 2005 at 02:55:03PM -0700, Andrew Morton wrote:
    > Kyle Moffett <mrmacman_g4@mac.com> wrote:
    > >
    > > While exploring the asm-*/types.h files, I discovered that the
    > > type "kmem_bufctl_t" is differently defined across each platform,
    > > sometimes as a short, and sometimes as an int. The only file
    > > where it's used is mm/slab.c, and as far as I can tell, that file
    > > doesn't care at all, aside from preferring it to be a small-sized
    > > type.
    >
    > I don't think there's any good reason for this. -mm's
    > slab-leak-detector.patch switches them all to unsigned long.

    What about moving it to include/linux/types.h ?

    cu
    Adrian 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Jeff Garzik: "[PATCH] change libata license from OSL+GPL to GPL"

    Relevant Pages

    • Re: drivers/w1/: why is dscore.c not ds9490r.c ?
      ... >> proprietary modules there might come some day open source drivers using ... >> them is not a reason). ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] USB_LIBUSUAL shouldnt be user-visible
      ... >> reason why a user should ever see this option. ... > No, it's not an implementation detail, it explicitly changes the way ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC: disallow modular framebuffers
      ... >> Is there any reason for these being three modules? ... of the darkness. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2/8] Fragmentation Avoidance V17: 002_usemap
      ... > You don't need to explicitly cast between int and unsigned long. ... > There needs to be a reason for the casts. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC: disallow modular framebuffers
      ... > BTW, what's the problem with the above? ... Is there any reason for these being three modules? ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    Loading