Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

From: Adrian Bunk (bunk_at_stusta.de)
Date: 08/30/05

  • Next message: Alan Cox: "Re: IDE HPA" 
    Date:	Tue, 30 Aug 2005 18:29:44 +0200
To: Olaf Hering <olh@suse.de>

    On Tue, Aug 30, 2005 at 06:18:14PM +0200, Olaf Hering wrote:
    > On Tue, Aug 30, Adrian Bunk wrote:
    >
    > > Currently, using an undeclared function gives a compile warning, but it
    > > can lead to a link or even a runtime error.
    > >
    > > With -Werror-implicit-function-declaration, we are getting an immediate
    > > compile error instead.
    >
    > You have to fix CONFIG_SWAP=n as well.
    >
    > http://lkml.org/lkml/2005/8/6/72

    I don't see any such warning in the 2.6.13 sparc build at Jan's
    crosscompile page [1], and all my patch does is to turn a warning into
    an error.

    If a #define is using it before the header with the prototype get's
    #include'd that's no problem as long as the prototype is available when
    the #define is _used_.

    I'm not saying that there aren't cases this patch will break (and my
    patch shouldn't go into 2.6.14), but your example doesn't seem to cause
    problems.

    cu
    Adrian

    [1] http://l4x.org/k/?d=6676 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Alan Cox: "Re: IDE HPA"

    Relevant Pages