Re: [PATCH] crypto_free_tfm callers do not need to check for NULL

From: Sridhar Samudrala (sri_at_us.ibm.com)
Date: 08/30/05

  • Next message: Jesper Juhl: "Re: Telecom Clock driver for MPCBL0010 ATCA compute blade." 
    To: Jesper Juhl <jesper.juhl@gmail.com>
Date:	Tue, 30 Aug 2005 14:13:35 -0700

    On Tue, 2005-08-30 at 22:45 +0200, Jesper Juhl wrote:
    > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in,
    > there's no longer any need for callers of that function to check for NULL.
    > This patch removes the redundant NULL checks and also a few similar checks
    > for NULL before calls to kfree() that I ran into while doing the
    > crypto_free_tfm bits.
    >
    > I've posted similar patches in the past, but was asked to first until the
    > short-circuit patch moved from -mm to mainline - and since it is now
    > firmly there in 2.6.13 I assume there's no problem there anymore.
    > I was also asked previously to make the patch against mainline and not -mm,
    > so this patch is against 2.6.13.
    >
    > Feedback, ACK, NACK, etc welcome.

    sctp change looks fine.
    A similar check in sctp_endpoint_destroy() can also be removed.

    Thanks
    Sridhar

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jesper Juhl: "Re: Telecom Clock driver for MPCBL0010 ATCA compute blade."

    Relevant Pages