[2.6 patch] drivers/serial/crisv10.c: remove {,un}register_serial dummies

From: Adrian Bunk (bunk_at_stusta.de)
Date: 09/02/05

  • Next message: Adrian Bunk: "[2.6 patch] feature-removal-schedule.txt: remove {,un}register_serial entry"
    Date:	Fri, 2 Sep 2005 01:12:58 +0200
    To: Linux Kernel List <linux-kernel@vger.kernel.org>, amax@us.ibm.com, ralf@linux-mips.org, starvik@axis.com
    
    

    On Wed, Aug 31, 2005 at 10:33:52AM +0100, Russell King wrote:
    >...
    > In addition, the following drivers declare functions of the same name.
    > The maintainers of these need to look to see why, and eliminate them
    > where possible.
    >
    > drivers/serial/crisv10.c:register_serial(struct serial_struct *req)
    > drivers/serial/crisv10.c:void unregister_serial(int line)

    It seems we can simply kill these dummies with this patch.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.13-mm1-full/drivers/serial/crisv10.c.old 2005-09-02 01:10:07.000000000 +0200
    +++ linux-2.6.13-mm1-full/drivers/serial/crisv10.c 2005-09-02 01:10:27.000000000 +0200
    @@ -5038,17 +5038,3 @@
     /* this makes sure that rs_init is called during kernel boot */
     
     module_init(rs_init);
    -
    -/*
    - * register_serial and unregister_serial allows for serial ports to be
    - * configured at run-time, to support PCMCIA modems.
    - */
    -int
    -register_serial(struct serial_struct *req)
    -{
    - return -1;
    -}
    -
    -void unregister_serial(int line)
    -{
    -}

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Adrian Bunk: "[2.6 patch] feature-removal-schedule.txt: remove {,un}register_serial entry"

    Relevant Pages

    • Re: [2.6 patch] drivers/serial/crisv10.c: remove {,un}register_serial dummies
      ... the following drivers declare functions of the same name. ... >> The maintainers of these need to look to see why, ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: Reproducable OOPS with MD RAID-5 on 2.6.0-test11
      ... >> look and see if anything obvious pops up, otherwise the maintainers of ... >> those areas should take a closer look. ... typedef struct dev_info dev_info_t; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 0/8] Cleanup slab.c
      ... please inline patches to the mail and cc ... > Manfred Spraul who more or less maintains mm/slab.c (curiously, ... > entry in MAINTAINERS though). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] mm/swap_state.c: unexport swapper_space
      ... > I disagree. ... swapper_state is far too much of an internal detail to be ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Small kfree cleanup, save a local variable.
      ... >> Patch also removes an extra space a little further down in the file. ... I didn't find that address in MAINTAINERS nor in the source file. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)