Re: [2/2] Change p[gum]d_clear_* inlines to macros to fix p?d_ERROR

From: Hugh Dickins (hugh_at_veritas.com)
Date: 09/10/05

  • Next message: James Bottomley: "Re: aic79xx oops" 
    Date:	Sat, 10 Sep 2005 16:02:20 +0100 (BST)
To: Andi Kleen <ak@suse.de>

    On Sat, 10 Sep 2005, Andi Kleen wrote:
    > On Saturday 10 September 2005 16:15, Hugh Dickins wrote:
    > > On Sat, 10 Sep 2005, Andi Kleen wrote:
    > > > Change p[gum]d_clear_* inlines to macros to fix p?d_ERROR
    > > >
    > > > When this code was refactored by Hugh it was moved out of the actual
    > > > functions into these inlines. The problem is that pgd_ERROR
    > > > uses __FUNCTION__ and __LINE__ to show where the error happened,
    > > > and with the inline that is pretty meaningless now because
    > > > it's the same for all callers.
    > > >
    > > > Change them to be macros to avoid this problem
    > >
    > > Please don't. It adds much less than I misremember (only 550 bytes
    > > to my i386 PAE config), but even so it's a waste of space.
    >
    > Hmm? Macros and inlines take the same amount of space.

    I expect they do, but that's not the issue. You're moving
    mm/memory.c's out-of-line p?d_clear_bad code inline (or into macro).

    > I have actually seen them while debugging something. But it was useless.
    > That is why I made the change.

    If you've found their __FUNCTION__ and __LINE__ useful,
    then I think you'll find the WARN_ON(1) backtrace even more so.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: James Bottomley: "Re: aic79xx oops"