Re: [PATCH 1/2][FAT] miss-sync issues on sync mount (miss-sync on write)

From: Andrew Morton (akpm_at_osdl.org)
Date: 09/15/05

  • Next message: Lee Revell: "Re: Automatic Configuration of a Kernel"
    Date:	Wed, 14 Sep 2005 19:48:20 -0700
    To: "Machida, Hiroyuki" <machida@sm.sony.co.jp>
    
    

    "Machida, Hiroyuki" <machida@sm.sony.co.jp> wrote:
    >
    > This patch fixes miss-sync issue on write() system call.
    > This updates inode attrs flags, mtime and ctime on every
    > comit_write call, due to locking.

    This all seems wrong.

    Why does fatfs have file_operations.write pointing at do_sync_write()
    rather than generic_file_write()?

    Why does fatfs have a custom .aio_write() rather than using
    generic_file_aio_write()?

    If fatfs can use all the standard library functions, all this inode
    dirtying and O_SYNC/-o sync handling shoud just work.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Lee Revell: "Re: Automatic Configuration of a Kernel"

    Relevant Pages

    • Re: [PATCH] FAT: Support synchronous update
      ... > If user specified that option, the fatfs does traditional ordered ... > updates by using synchronous writes. ... I put the modified fatfsprogs at ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6.8-rc2-bk] New read/write bug in FAT fs
      ... > unclear was deleted from fatfs. ... Right now NTFS uses "nls" and VFAT "iocharset". ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 24/29] FAT: Remove unneed mark_inode_dirty()
      ... not written) or change a ->i_nlink count only (fatfs don't have). ... goto out; ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [RFC] Rename SECTOR_SIZE to MSDOS_SECTOR_SIZE
      ... The fatfs doesn't use these. ... These are for just backward compatibility. ... To rename is not useful at all, please delete instead if it's needed. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)