[PATCH] Fix bogus cast in IXP2000 I/O macro

From: Deepak Saxena (dsaxena_at_plexity.net)
Date: 09/30/05

  • Next message: jerome lacoste: "Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel" 
    Date:	Thu, 29 Sep 2005 15:52:41 -0700
To: Linus Torvalds <torvalds@osdl.org>, rmk@arm.linux.org.uk

    Physical addresses are not valid pointers of any sort and should not be cast
    to such.

    Signed-off-by: Deepak Saxena <dsaxena@plexity.net>

    diff --git a/include/asm-arm/arch-ixp2000/ixdp2x01.h b/include/asm-arm/arch-ixp2000/ixdp2x01.h
    --- a/include/asm-arm/arch-ixp2000/ixdp2x01.h
    +++ b/include/asm-arm/arch-ixp2000/ixdp2x01.h
    @@ -22,7 +22,7 @@
     #define IXDP2X01_CPLD_REGION_SIZE 0x00100000
     
     #define IXDP2X01_CPLD_VIRT_REG(reg) (volatile unsigned long*)(IXDP2X01_VIRT_CPLD_BASE | reg)
    -#define IXDP2X01_CPLD_PHYS_REG(reg) (volatile u32*)(IXDP2X01_PHYS_CPLD_BASE | reg)
    +#define IXDP2X01_CPLD_PHYS_REG(reg) (IXDP2X01_PHYS_CPLD_BASE | reg)
     
     #define IXDP2X01_UART1_VIRT_BASE IXDP2X01_CPLD_VIRT_REG(0x40)
     #define IXDP2X01_UART1_PHYS_BASE IXDP2X01_CPLD_PHYS_REG(0x40) 

    -- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net
Even a stopped clock gives the right time twice a day.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: jerome lacoste: "Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel"

    Relevant Pages