[PATCH] Revert [PATCH] x86-64: Reverse order of bootmem lists

• Previous message: Luben Tuikov: "Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

To: linux-kernel@vger.kernel.org
Date:	Fri, 30 Sep 2005 21:27:00 +0200

Linus,

please revert the patch

http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5d3d0f7704ed0bc7eaca0501eeae3e5da1ea6c87

as it breaks a couple of ARM boards, which depend on the historical
bootmem allocation order. AFAIK there is a cleaner solution around to
remove the pgdat list completely, but this is a topic for post 2.6.14

Andi signalled ACK already.

tglx

Index: linux-2.6.14-rc2-genirq/mm/bootmem.c
===================================================================
--- linux-2.6.14-rc2-genirq.orig/mm/bootmem.c
+++ linux-2.6.14-rc2-genirq/mm/bootmem.c
@@ -61,17 +61,9 @@ static unsigned long __init init_bootmem
 {
         bootmem_data_t *bdata = pgdat->bdata;
         unsigned long mapsize = ((end - start)+7)/8;
- static struct pglist_data *pgdat_last;
 
- pgdat->pgdat_next = NULL;
- /* Add new nodes last so that bootmem always starts
- searching in the first nodes, not the last ones */
- if (pgdat_last)
- pgdat_last->pgdat_next = pgdat;
- else {
- pgdat_list = pgdat;
- pgdat_last = pgdat;
- }
+ pgdat->pgdat_next = pgdat_list;
+ pgdat_list = pgdat;
 
         mapsize = ALIGN(mapsize, sizeof(long));
         bdata->node_bootmem_map = phys_to_virt(mapstart << PAGE_SHIFT);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Previous message: Luben Tuikov: "Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]