Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface

From: KAMEZAWA Hiroyuki (kamezawa.hiroyu_at_jp.fujitsu.com)
Date: 10/21/05

  • Next message: Magnus Damm: "Re: [PATCH 1/4] Swap migration V3: LRU operations" 
    Date:	Fri, 21 Oct 2005 16:20:42 +0900
To: Simon Derr <Simon.Derr@bull.net>

    > Christoph Lameter wrote:
    >
    >>> > + /* Is the user allowed to access the target nodes? */
    >>> > + if (!nodes_subset(new, cpuset_mems_allowed(task)))
    >>> > + return -EPERM;
    >>> > +
    >
    >> How about this ?
    >> +cpuset_update_task_mems_allowed(task, new); (this isn't implemented now

    *new* is already guaranteed to be the subset of current mem_allowed.
    Is this violate the permission ?

    Simon Derr wrote:
    > Automatically updating the ->mems_allowed field as you suggest would
    > require that the kernel do the same checks in sys_migrage_pages(). Sounds
    > not as a very good idea to me.

    Hmm, it means a user or admin should modify mem_allowed
    before the first page fault after calling sys_migrate_pages().

    -- Kame

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Magnus Damm: "Re: [PATCH 1/4] Swap migration V3: LRU operations"

    Relevant Pages