Re: ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attached PHYs)

From: Luben Tuikov (luben_tuikov_at_adaptec.com)
Date: 10/21/05

  • Next message: Kristen Accardi: "Re: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter" 
    Date:	Fri, 21 Oct 2005 17:24:54 -0400
To: Jeff Garzik <jgarzik@pobox.com>

    On 10/21/05 17:12, Jeff Garzik wrote:
    >
    > I already described why. Examples are DMA boundary and s/g limit, among
    > others. When confronted with this, you proposed an additional hardware
    > information struct which duplicates Scsi_Host_Template.

    I told you -- I have this in the struct asd_ha_struct and it was merely
    a downplay that I didn't include the same thing in struct sas_ha_struct.

    > Solution? Just use Scsi_Host_Template. Take a look at how each libata

    No, this is the solution which would turn everything upside down.
    The easiest and smallest solution is to just include this tiny struct
    and end this. It would have 0 impact on code. In fact I'll
    implement it now and push it to the git tree. ;-)

    The host template _mixes_ hw, scsi core, and protocol knowlege into
    one ugly blob. I've given this argument before, several times.

    > driver is implemented. The host template is in the low level driver,
    > while most of the code is common code, implemented elsewhere.

    libata isn't without architectural problems. What strikes me is
    that you think that libata-scsi is SATL.

    You are so much better off renaming it to satl.c and given
    the knowlege you've gained over the years and the backing you have
    from engineers from companies, start with it at device level. I, as
    I'm sure other (not to name names) will be more than happy to contribute
    if you started this.

            Luben 

    -- 
http://linux.adaptec.com/sas/
http://www.adaptec.com/sas/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Kristen Accardi: "Re: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter"

    Relevant Pages

    • [git patches] libata updates
      ... libata: ata_scsi_queuecmd cleanup ... static struct ata_probe_ent * ... int index, fua, lba48, write; ... goto out_of_range; ...
      (Linux-Kernel)
    • [sata] libata queue updated
      ... o [libata] improve translation of ATA errors to SCSI sense codes ... o remove 'packed' attributed from struct ata_prd ... static int piix_init_one (struct pci_dev *pdev, ... +static void ata_pio_block ...
      (Linux-Kernel)
    • [SATA] libata-dev queue updated
      ... o [libata scsi] support 12-byte passthru CDB ... +struct ahci_cmd_hdr { ... +static inline unsigned long ahci_port_base_ul (unsigned long base, unsigned int port) ... +static void ahci_port_stop ...
      (Linux-Kernel)
    • [git patches] libata fixes
      ... If you have not pulled from Tejun, ... libata: remove unused functions ... Return proper ATA INT status in pata_bf54x driver ... struct ata_host *host; ...
      (Linux-Kernel)
    • [RFT #2] libata (SATA) driver fixes
      ... See attached changelog and patch, ... This includes some fixes for some ugly probe-related bugs, ... o [libata sata_sil] add another Seagate drive to blacklist ... +static struct ata_probe_ent * ...
      (Linux-Kernel)