Re: Notifier chains are unsafe
From: Keith Owens (kaos_at_ocs.com.au)
Date: 10/28/05
- Previous message: Jeff Garzik: "[git patches] 2.6.x net driver updates"
- In reply to: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Next in thread: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Reply: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: sekharan@us.ibm.com Date: Fri, 28 Oct 2005 10:48:00 +1000
On Thu, 27 Oct 2005 16:02:08 -0700,
Chandra Seetharaman <sekharan@us.ibm.com> wrote:
>On Thu, 2005-10-27 at 17:21 -0400, Alan Stern wrote:
>> The other problem is that you violated Keith's statement that
>> notifier_call_chain shouldn't take any locks. On the other hand, if we
>
>I would interpret Keith's comment like this: callout should not be
>called with any locks held (because that would limit the callouts from
>blocking).
We should be able to call notifier_call_chain() from any context. That
includes oops, panic, NMI and other unmaskable machine check events.
If you can call notifier_call_chain() from an unmaskable context then
it follows that the callbacks cannot take any locks. Locks are not
safe in NMI context.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jeff Garzik: "[git patches] 2.6.x net driver updates"
- In reply to: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Next in thread: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Reply: Chandra Seetharaman: "Re: Notifier chains are unsafe"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|