Re: Commit "[PATCH] USB: Always do usb-handoff" breaks my powerbook

From: Benjamin Herrenschmidt (benh_at_kernel.crashing.org)
Date: 11/01/05

  • Next message: Paul Mackerras: "Re: [PATCH 1/20] inflate: lindent and manual formatting changes" 
    To: Paul Mackerras <paulus@samba.org>
Date:	Tue, 01 Nov 2005 11:16:54 +1100

    On Mon, 2005-10-31 at 16:23 +1100, Paul Mackerras wrote:
    > My G4 powerbook gets a machine check on boot as a result of commit
    > 478a3bab8c87a9ba4a4ba338314e32bb0c378e62. Putting a return at the
    > start of quirk_usb_early_handoff fixes it.
    >
    > The code in quirk_usb_handoff_ohci looks rather bogus in that it
    > doesn't do pci_enable_device before trying to access the device.

    That and it doesn't test if the BARs are assigned at all, doesn't
    request the resources, etc...

    I'm not sure it's legal to do pci_enable_device() from within a pci
    quirk anyway. I really wonder what that code is doing in the quirks, I
    don't think it's the right place, but I may be wrong.

    What is the logic supposed to be there ?

    Ben.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Paul Mackerras: "Re: [PATCH 1/20] inflate: lindent and manual formatting changes"

    Relevant Pages

    • Commit "[PATCH] USB: Always do usb-handoff" breaks my powerbook
      ... My G4 powerbook gets a machine check on boot as a result of commit ... start of quirk_usb_early_handoff fixes it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 64 bit kernel
      ... the chipset "fooled" the OS into thinking that it was doing 32 bit wide operations. ... kernel problem or if it's a BIOS problem. ... After some searching I found others with similar problems and they had to use "noapic nolapic" kernel boot options to install and boot the OS. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: RFC: [2.6 patch] better i386 CPU selection
      ... If we boot a 386 kernel on a ppro with that bug, ... For the handful of bytes saved in the mtrr driver, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • fastboot, diskstat
      ... that the total time for prefetching + actual boot was only 10% shorter, ... actually cache the pages I touched, ... Also, regarding the directory entries, are they accessed via the buffer ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: VST patches ported to 2.6.11-rc1
      ... Yes we want to boot with it disabled. ... >>Both of these arrays are kept as circular lists and read back such ... getting the VST sleeps he wants. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)