Re: [PATCH] hfsplus: don't modify journaled volume

From: Anton Altaparmakov (aia21_at_cam.ac.uk)
Date: 11/05/05

  • Next message: Francois Romieu: "Re: New Linux Development Model"
    Date:	Sat, 5 Nov 2005 10:13:19 +0000 (GMT)
    To: Andrew Morton <akpm@osdl.org>
    
    

    On Fri, 4 Nov 2005, Andrew Morton wrote:
    > Roman Zippel <zippel@linux-m68k.org> wrote:
    > >
    > > + } else if (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED)) {
    > > + printk("HFS+-fs: Filesystem is marked journaled, leaving read-only.\n");
    > > + sb->s_flags |= MS_RDONLY;
    > > + *flags |= MS_RDONLY;
    >
    > These sorts of printks should have an explicit facility level, no?

    I would agree with that and further, is that not a bit draconian?
    HFSPlus is designed to work without the journal. Just change the last
    mounted version to FSK! (0x46534b21) and everything will work as expected,
    i.e. fsck will run a check instead of ignoring the volume and osx will
    mount the volume and reinitialize the journal. Remember older OSX
    versions did not support journalling so if you attached your external
    drive to one of those older osx boxes, you would also get non-journalled
    writes to a journalled volume. It's all designed for it...

    Best regards,

            Anton

    -- 
    Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
    Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
    Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
    WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Francois Romieu: "Re: New Linux Development Model"

    Relevant Pages

    • Re: [PATCH] hfsplus: dont modify journaled volume
      ... Remember older OSX ... > versions did not support journalling so if you attached your external ... Linux NTFS maintainer / IRC: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: mode data=journal in ext3. Is it safe to use?
      ... And please tell me -- the point of journalling is to reduce fsck times ... Next time I reformat/get a new drive, I'll be going back to ext3 - ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [TRIVIAL] use ext2/ext3 consistently in Kconfig
      ... Ext3 is the journalling versions of the second extended file system ... Ext2 was the former de-facto standard Linux file system. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: data loss on jffs2 filesystem on dataflash
      ... Journalling filesystems actually would be robust against 4-6, ... Ext3 blocks are much smaller, so the fs would still corrupt. ... problem of limited per-block flash lifetime and ext3 doesn't do wear ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)